Skip to content

Document SQL literal syntax and escaping - #14934

Merged
alamb merged 5 commits into
apache:mainfrom
alamb:alamb/doc_literals
Feb 28, 2025
Merged

Document SQL literal syntax and escaping#14934
alamb merged 5 commits into
apache:mainfrom
alamb:alamb/doc_literals

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

When we remove the unescaping from datafusion-cli I think it is important to document how to properly used escaped values

What changes are included in this PR?

  1. Add documentation about escaping
  2. Add a slt test showing E strings working

Are these changes tested?

I reviewed the changes locally:

Screenshot 2025-02-28 at 7 13 01 AM
Screenshot 2025-02-28 at 7 13 24 AM

Are there any user-facing changes?

@alamb
alamb marked this pull request as ready for review February 28, 2025 12:22
@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt) labels Feb 28, 2025

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @alamb

@alamb

Copy link
Copy Markdown
ContributorAuthor

Thank you for the review @comphead

@alamb
alamb merged commit f9f256c into apache:mainFeb 28, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsqllogictestSQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@comphead