Skip to content

Workaround verification script error for branch-46 - #14983

Closed
alamb wants to merge 2 commits into
apache:branch-46from
alamb:alamb/fix_verification
Closed

Workaround verification script error for branch-46#14983
alamb wants to merge 2 commits into
apache:branch-46from
alamb:alamb/fix_verification

Conversation

@alamb

@alambalamb commented Mar 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

I am not sure why but the verification script started failing (see #14982)

Could also be related to

What changes are included in this PR?

Remove rust toolchain toml override file

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation sql SQL Planner development-process Related to development process of DataFusion logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate functions Changes to functions implementation labels Mar 3, 2025
@alamb
alambforce-pushed the alamb/fix_verification branch from ae89569 to a18c7d1CompareMarch 3, 2025 16:18
@github-actionsgithub-actionsBot removed documentation Improvements or additions to documentation sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates optimizer Optimizer rules core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate functions Changes to functions implementation labels Mar 3, 2025
@alambalamb changed the title Alamb/fix verificationFix verification script for branch-46Mar 3, 2025
@alamb
alamb marked this pull request as ready for review March 3, 2025 16:23
@alambalamb changed the title Fix verification script for branch-46Workaround verification script error for branch-46Mar 3, 2025
@andygrove

andygrove commented Mar 3, 2025

Copy link
Copy Markdown
Member

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

@andygrove

andygrove commented Mar 3, 2025

Copy link
Copy Markdown
Member

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

I may need to update Comet's toolchain file to match. I will try that next.

@alamb

alamb commented Mar 3, 2025

Copy link
Copy Markdown
ContributorAuthor

I run into the same issue when using 46.0.0-rc1 in Comet, and this PR will not help with that.

I may need to update Comet's toolchain file to match. I will try that next.

I think there is something that broke with rustup:

We also hit the issue with CI as well

@alamb

alamb commented Mar 3, 2025

Copy link
Copy Markdown
ContributorAuthor

have a better plan

@alambalamb closed this Mar 3, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

development-processRelated to development process of DataFusion

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alamb@andygrove