Skip to content

Do not double alias Exprs - #15008

Closed
alamb wants to merge 3 commits into
apache:mainfrom
alamb:alamb/extra_alias
Closed

Do not double alias Exprs#15008
alamb wants to merge 3 commits into
apache:mainfrom
alamb:alamb/extra_alias

Conversation

@alamb

@alambalamb commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Nested Expr::Alias is confusing for display and for dealing with code

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Mar 4, 2025
@github-actionsgithub-actionsBot added the optimizer Optimizer rules label Mar 5, 2025
This was referenced Mar 4, 2025
Merged
Closed
@alamb

alamb commented Mar 5, 2025

Copy link
Copy Markdown
ContributorAuthor

Let's go with @blaginin 's version here:

@alambalamb closed this Mar 5, 2025
phillipleblanc added a commit to spiceai/datafusion that referenced this pull request May 7, 2025
@phillipleblanc
Do not double alias Exprs
c809148
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
sgrebnov pushed a commit to spiceai/datafusion that referenced this pull request May 22, 2025
@phillipleblanc@sgrebnov
Do not double alias Exprs
0c63e2c
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
# Conflicts:
#	datafusion/expr/src/expr.rs
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 24, 2025
@sgrebnov
Improve unalias_nested
72be1cb
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 24, 2025
@sgrebnov
Improve Do not double alias Exprs
a85a085
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 26, 2025
@sgrebnov
Do not double alias Exprs
61e4a0e
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
sgrebnov added a commit to spiceai/datafusion that referenced this pull request May 26, 2025
@sgrebnov
Do not double alias Exprs
0bfa63a
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
kczimm pushed a commit to spiceai/datafusion that referenced this pull request Aug 19, 2025
@sgrebnov@kczimm
Do not double alias Exprs
6aaf1f5
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Jeadie pushed a commit to spiceai/datafusion that referenced this pull request Sep 9, 2025
@sgrebnov@Jeadie
Do not double alias Exprs
f292987
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Jeadie pushed a commit to spiceai/datafusion that referenced this pull request Sep 12, 2025
@sgrebnov@Jeadie
Do not double alias Exprs
547485d
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
peasee pushed a commit to spiceai/datafusion that referenced this pull request Oct 27, 2025
@sgrebnov@peasee
Do not double alias Exprs
abfdc26
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
peasee added a commit to spiceai/datafusion that referenced this pull request Oct 27, 2025
@peasee@phillipleblanc
@kczimm@sgrebnov@Jeadie@krinart@mach-kernel
feat: Update for Datafusion v50 (#109)
cd6b2f8
* fix: Ensure only tables or aliases that exist are projected (#52)
fix: More dangling references (#54)
UPSTREAM NOTE: This PR was attempted to be upstreamed in apache#13405 - but it was not accepted due to the complexity it brought. Phillip needs to figure out what a good solution that solves our problem and can be upstreamed is.
* Support for metadata columns (`location`, `size`, `last_modified`) in ListingTableProvider (#74)
UPSTREAM NOTE: This PR was attempted to be upstreamed but was not accepted. Needs to be applied manually
apache#15181
* Infer placeholder datatype for `Expr::InSubquery` (#80)
UPSTREAM NOTE: Upstream PR has been created but not merged yet. Should be available in DF49
apache#15980
* Infer placeholder datatype after `LIMIT` clause as `DataType::Int64` (#81)
UPSTREAM NOTE: Upstream PR has been created but not merged yet. Should be available in DF49
apache#15980
* Do not double alias Exprs
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
* Add prefix to location metadata column (#82)
UPSTREAM NOTE: This will not be upstreamed as is.
* Infer placeholder types for CASE expressions (#87)
UPSTREAM NOTE: This has not been submitted upstream yet.
* Expand `infer_placeholder_types` to infer all possible placeholder types based on their expression (#88)
UPSTREAM NOTE: This has not been submitted upstream yet.
* Fix `Expr::infer_placeholder_types` inference to not fail (#89)
UPSTREAM NOTE: This has not been submitted upstream yet.
* cherry-pick parquet patch (#94)
* Fix array types coercion: preserve child element nullability for list types (#96)
UPSTREAM NOTE: This was submitted upstream and should be available in DF50
apache#17306
* Expand `infer_placeholder_types` to infer all possible placeholder types based on their expression (#88)
UPSTREAM NOTE: This has not been submitted upstream yet.
* do not enforce type guarantees on all Expr traversed in infer_placeholder_types (#97)
* Use UDTF function args in `LogicalPlan::TableScan` name (#98)
* use UDTF function args in LogicalPlan::TableScan name
* update test snapshots
* Implement timestamp_cast_dtype for SqliteDialect (#99)
* Use text for sqlite timestamp
* Add test
* Custom timestamp format for DuckDB (#102)
* Revert "cherry-pick parquet patch (#94)"
This reverts commit d780cc2.
* Support ExprNamed arguments to Scalar UDFs (#104)
* support ExprNamed until 17379 ships
* add same exprnamed lifting to udtf
* resolve projection against `ListingTable` table_schema incl. partition columns (#106)
* fix: Ensure ListingTable partitions are pruned when filters are not used (#108)
* fix: Prune partitions when no filters are defined
* fix: Backport for DF49:
* review: Address comments
* FileScanConfig: Preserve schema metadata across serde boundary (#107)
* FileScanConfig: preserve schema metadata across serde boundary
* add test
* Merge conflict fixes
UPSTREAM NOTE: this should not be upstreamed. This contains conflict fixes from various cherry-picks and differences in v50.
* update arrow-rs fork
UPSTREAM NOTE: this should not be upstreamed
---------
Co-authored-by: Phillip LeBlanc <phillip@leblanc.tech>
Co-authored-by: Kevin Zimmerman <4733573+kczimm@users.noreply.github.com>
Co-authored-by: sgrebnov <sergei.grebnov@gmail.com>
Co-authored-by: jeadie <jack@spice.ai>
Co-authored-by: Jack Eadie <jack.eadie0@gmail.com>
Co-authored-by: Viktor Yershov <krinart@gmail.com>
Co-authored-by: Viktor Yershov <viktor@spice.ai>
Co-authored-by: David Stancu <david@spice.ai>
phillipleblanc pushed a commit to spiceai/datafusion that referenced this pull request Jan 20, 2026
@sgrebnov@phillipleblanc
Do not double alias Exprs
92178c1
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
lukekim pushed a commit to spiceai/datafusion that referenced this pull request Feb 13, 2026
@sgrebnov@lukekim
Do not double alias Exprs
c26dfe1
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
lukekim pushed a commit to spiceai/datafusion that referenced this pull request Feb 19, 2026
@sgrebnov@lukekim
Do not double alias Exprs
a7b0056
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
lukekim pushed a commit to spiceai/datafusion that referenced this pull request Feb 26, 2026
@sgrebnov@lukekim
Do not double alias Exprs
c703d72
UPSTREAM NOTE: This was attempted to be fixed with
apache#15008 but was closed
This is the tracking issue on DataFusion:
apache#14895
Do not double alias Exprs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

logical-exprLogical plan and expressionsoptimizerOptimizer rulessqllogictestSQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove duplicated alias in Sort

1 participant

@alamb