Uh oh!
There was an error while loading. Please reload this page.
Split out datafusion-substrait and datafusion-proto CI feature checks, increase coverage - #15156
Merged
Conversation
datafusion-substrait and datafusion-proto CI feature checksalamb
commented
Mar 11, 2025
| # | ||
| # Ensure via `cargo check` that the crate can be built with a | ||
| # subset of the features packages enabled. | ||
| linux-datafusion-common-features: |
ContributorAuthor
There was a problem hiding this comment.
The diff makes of hard to read but I just moved what jobs each command was run in -- the overall coverage is the same or better
| rust-version: stable | ||
| - name: Check datafusion-substrait (no-default-features) | ||
| run: cargo check --profile ci --all-targets --no-default-features -p datafusion-substrait | ||
| - name: Check datafusion-substrait (physical) |
ContributorAuthor
There was a problem hiding this comment.
this adds coverage of compiling datafusion-substrait with the available feature flags
3 tasks
alamb
commented
Mar 11, 2025
| rust-version: stable | ||
| - name: Check datafusion-proto (no-default-features) | ||
| run: cargo check --profile ci --all-targets --no-default-features -p datafusion-proto | ||
| # fails due to https://github.com/apache/datafusion/issues/15157 |
ContributorAuthor
There was a problem hiding this comment.
This adds coverage for the datafusion-proto crate, and in fact found a bug:
datafusion-substrait and datafusion-proto CI feature checksdatafusion-substrait and datafusion-proto CI feature checks, increase coveragealamb
marked this pull request as ready for review
March 11, 2025 14:57
timsaucer
approved these changes
Mar 11, 2025
timsaucer
left a comment
Member
There was a problem hiding this comment.
This all looks very reasonable to me and a good improvement. I left a note in the issue you raised that we will want to follow up on the commented out check.
alamb
commented
Mar 11, 2025
ContributorAuthor
Thank you for the review @timsaucer ! |
datafusion-substrait and datafusion-proto CI feature checks, increase coveragedatafusion-substrait and datafusion-proto CI feature checks, increase coveragedatafusion-substrait and datafusion-proto CI feature checks, increase coveragedatafusion-substrait and datafusion-proto CI feature checks, increase coverage
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The coverage for feature flags needs to be improved, as explained on #15155
What changes are included in this PR?
Note I will make a follow on PR to add additional coverage for flags in
datafusion-functionsanddatafusionbut I am trying to keep this PR reasonably sizedAre these changes tested?
Are there any user-facing changes?