Uh oh!
There was an error while loading. Please reload this page.
Minor: consistently apply clippy::clone_on_ref_ptr in all crates - #15284
Merged
Conversation
alamb
commented
Mar 17, 2025
| state.aggregate_functions().clone(), | ||
| state.window_functions().clone(), | ||
| state.runtime_env().clone(), | ||
| Arc::clone(state.runtime_env()), |
ContributorAuthor
There was a problem hiding this comment.
this shows what the lint disallows -- when it is an Arc it must use Arc::clone rather than .clone() so it is easier to see when reading the code that no copies are made
Contributor
There was a problem hiding this comment.
I always wondered what the motivation of the lint is 😆
ContributorAuthor
There was a problem hiding this comment.
That is a good point -- I'll add some comments explaining it
alamb
marked this pull request as ready for review
March 17, 2025 20:34
adriangb
approved these changes
Mar 17, 2025
alamb
commented
Mar 18, 2025
ContributorAuthor
berkaysynnada
commented
Mar 18, 2025
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Some of the newer DataFusion crates don't have the
clippy::clone_on_ref_ptrlint enabled. This lint is present to make it clear whenclone()is very cheap (because it is on an Arc rather than some structure that requires deep copyingWhat changes are included in this PR?
Here is an example of the lint enabled in the core crate
datafusion/datafusion/core/src/lib.rs
Line 24 in 5224194
Are these changes tested?
By CI
Are there any user-facing changes?
No