Skip to content

Clarify docs about Accumulator::update and Accumulator::update_batch - #1542

Merged
alamb merged 3 commits into
apache:masterfrom
alamb:alamb/update_comments
Jan 11, 2022
Merged

Clarify docs about Accumulator::update and Accumulator::update_batch#1542
alamb merged 3 commits into
apache:masterfrom
alamb:alamb/update_comments

Conversation

@alamb

@alambalamb commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Rationale

As discussed with @realno on #1525 at #1525 (comment)
the distinction between Accumulator::updateandAccumulator::update_batch` was not 100% clear

Changes

Try to clarify the distinction using doc comments

@alambalamb mentioned this pull request Jan 10, 2022
Merged
@realno

realno commented Jan 10, 2022

Copy link
Copy Markdown
Contributor

Perhaps we can also add the same notes on merge_batch, I think it applies there too.

houqp
houqp approved these changes Jan 11, 2022
View reviewed changes
Comment threaddatafusion/src/physical_plan/mod.rs Outdated
@houqphouqp added the documentation Improvements or additions to documentation label Jan 11, 2022
@alamb

alamb commented Jan 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Perhaps we can also add the same notes on merge_batch, I think it applies there too.

Added in e37679f

@alamb
alamb merged commit b42ebe7 into apache:masterJan 11, 2022
@alambalamb mentioned this pull request Jan 11, 2022
Closed
@alamb
alamb deleted the alamb/update_comments branch August 8, 2023 20:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@houqphouqphouqp approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@realno@houqp