Skip to content

Add covar, covar_pop and covar_samp aggregate functions - #1551

Merged
alamb merged 13 commits into
apache:masterfrom
realno:add-covar-operators
Jan 13, 2022
Merged

Add covar, covar_pop and covar_samp aggregate functions#1551
alamb merged 13 commits into
apache:masterfrom
realno:add-covar-operators

Conversation

@realno

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes#1548 .

Rationale for this change

This PR adds covar, covar_pop and covar_samp statistical functions as aggregators to DataFusion.

What changes are included in this PR?

Are there any user-facing changes?

The following operators are added:
covar
covar_pop
covar_samp

No breaking changes.

@github-actionsgithub-actionsBot added ballista documentation Improvements or additions to documentation labels Jan 11, 2022
Ok(())
}

#[test]

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some test for variance to test merge rules.

Ok(())
}

#[test]

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests for merge rule.

@liukun4515

Copy link
Copy Markdown
Contributor

Thank you for your works! @realno

@houqphouqp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liukun4515liukun4515 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
alamb merged commit b4c77e5 into apache:masterJan 13, 2022
@alamb

Copy link
Copy Markdown
Contributor

Thanks @realno@houqp and @liukun4515 -- I didn't review this code but I trust your reviews 👍

@realnorealno mentioned this pull request Jan 14, 2022
@realno
realno deleted the add-covar-operators branch February 9, 2022 20:09
@alambalamb changed the title Add covar operatorsAdd covar, covar_pop and covar_samp aggregate functionsFeb 10, 2022
@alambalamb added enhancement New feature or request and removed documentation Improvements or additions to documentation labels Feb 10, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add covar operators to DataFusion

4 participants

@realno@liukun4515@alamb@houqp