Uh oh!
There was an error while loading. Please reload this page.
Fix new clippy lints introduced in Rust 1.58 - #1555
Closed
alamb wants to merge 1 commit into
Closed
Conversation
houqp
approved these changes
Jan 14, 2022
houqp
commented
Jan 14, 2022
Member
looks like this is a subset of #1557? |
alamb
commented
Jan 14, 2022
ContributorAuthor
Yes, I think #1557 from @xudong963 looks better 👍 closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Its that time of month! Rust 1.58 has been released and with it some new clippy lints.
https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1580-2022-01-13
This PR updates DataFusion so it passes the new more stringent clippy.
Overall I would say it is a nice improvement