Uh oh!
There was an error while loading. Please reload this page.
Show current SQL recursion limit in RecursionLimitExceeded error message - #15644
Conversation
4ed10ff to
93f771eCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
91da480 to
b1fbfe8Comparekumarlokesh
commented
Apr 18, 2025
@comphead updated the PR after resolving merge conflicts. |
comphead
left a comment
There was a problem hiding this comment.
thanks @kumarlokesh The code now looks much more aligned.
perhaps we can factor out
self.parser
.parse_statement()
.map(|stmt| Statement::Statement(Box::from(stmt)))
.map_err(|e| match e {
ParserError::RecursionLimitExceeded => {
DataFusionError::SQL(
ParserError::RecursionLimitExceeded,
Some(format!(
" (current limit: {})",
self.options.recursion_limit
)),
)
}
other => DataFusionError::SQL(other, None),
})
into helper method
But it can be done in followup PR
xudong963
commented
Apr 19, 2025
+1 for this to reduce duplicated code |
kumarlokesh
commented
Apr 20, 2025
@comphead@xudong963 addressed here dea5fe5. |
xudong963
left a comment
There was a problem hiding this comment.
Thank you @kumarlokesh@comphead
…age (apache#15644) * Show current SQL recursion limit in RecursionLimitExceeded error message * use recursion_limit setting from sql-parser-options * resolve merge conflicts * move error handling code to helper method
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
recursion_limit(available through SQL parser options) field toDFParserstruct to track the current recursion limit
COPY INTOstatementsSQL error: RecursionLimitExceeded (current limit: {recursion_limit})Are these changes tested?
Are there any user-facing changes?