Uh oh!
There was an error while loading. Please reload this page.
consolidate binary_expr coercion rule code into binary_rule.rs module - #1607
Conversation
alamb
commented
Jan 18, 2022
cc @liukun4515 |
liukun4515
commented
Jan 19, 2022
Thanks @alamb |
liukun4515
commented
Jan 19, 2022
If #1606 merged, I will review this. |
No worries @liukun4515 -- you said that. I just figured I was already changing the code for #1606 so I would make progress here too Also note there is no actual consolidation of the logic -- I just moved the code to the same module. I envision your cleanup to consolidate the actual logic would be in a follow on PR |
0c3ee94 to
90d9a27Comparebinary_rule.rs module90d9a27 to
c065f05CompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: xudong.w <wxd963996380@gmail.com>
| } | ||
| /// Determine if a DataType is signed numeric or not | ||
| pub fn is_signed_numeric(dt: &DataType) -> bool { |
| } | ||
| /// Determine if a DataType is numeric or not | ||
| pub fn is_numeric(dt: &DataType) -> bool { |
| } | ||
| } | ||
| pub(crate) fn is_dictionary(t: &DataType) -> bool { |
Builds on #1606, so draft until that is mergedWhich issue does this PR close?
Re #1605
Rationale for this change
While working on #1606 I found it confusing that some of the logic was in
coercion.rsand some inbinary_rule.rsWhat changes are included in this PR?
Moves all binary operator coercion logic into
binary_rule.rs(just code motion, no changes now). I hope that the logic is consolidated more in a future PRAre there any user-facing changes?
no