Uh oh!
There was an error while loading. Please reload this page.
Add dicts to aggregation fuzz testing - #16232
Merged
Merged
Conversation
blaginin
marked this pull request as ready for review
June 2, 2025 16:36
alamb
approved these changes
Jun 4, 2025
| UInt32Type, | ||
| values | ||
| ), | ||
| DataType::UInt64 => generate_dict!( |
Contributor
There was a problem hiding this comment.
I think technically since only Dictionary(UInt64, Utf8) is made, we can avoid all the other cases in this match statement and save on codegen
blaginin
commented
Jun 4, 2025
MemberAuthor
Thanks for the review!
It won't fail because of Once #16228 is fixed, we'll be able to generate null values in both keys and values (will extend the ticket once this PR is merged) |
alamb
reviewed
Jun 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Jun 4, 2025
Contributor
Make sense -- that would be great context to add as a comment. I left a suggestion |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
kosiew pushed a commit
to kosiew/datafusion
that referenced
this pull request
Jun 10, 2025
* Add dicts to fuzzy testing * Add a note on `0.0` Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Remove unused key types --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #15871 (comment)
Rationale for this change
Adds dicts support for fuzzy testing when doing aggregation (to test prs like Related to #15871)
Are these changes tested?
Are there any user-facing changes?
No