Uh oh!
There was an error while loading. Please reload this page.
remove unused methods in SortExec - #16457
Merged
Merged
Conversation
comphead
left a comment
Contributor
There was a problem hiding this comment.
these are pubs, it can be in use in downstream projects.
Please mark them deprecated
adriangb
commented
Jun 19, 2025
ContributorAuthor
We just added them in #15770 2 days ago. I'm 99% certain no downstream projects are using them. I feel it would be less painful to just rip them out right now rather than having them go into the next release as deprecated. |
comphead
commented
Jun 19, 2025
Contributor
Agree |
comphead
approved these changes
Jun 19, 2025
adriangb
commented
Jun 19, 2025
ContributorAuthor
Thanks for the review @comphead ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts unnecessary methods added in #15770