Uh oh!
There was an error while loading. Please reload this page.
Support query filter on all benchmarks - #16477
Merged
Merged
Conversation
pepijnveforce-pushed
the
bench_query_filter
branch
from
June 20, 2025 12:27
63c432f to
8b9f844Comparealamb
previously approved these changes
Jun 21, 2025
alamb
left a comment
Contributor
There was a problem hiding this comment.
I ran the following command:
(venv) andrewlamb@Andrews-MacBook-Pro-3:~/Software/datafusion$ ./benchmarks/bench.sh run clickbench_partitioned
And it passes n main but fails on this branch:
Running `/Users/andrewlamb/Software/datafusion/target/release/dfbench clickbench --iterations 5 --path /Users/andrewlamb/Software/datafusion/benchmarks/data/hits_partitioned --queries-path /Users/andrewlamb/Software/datafusion/benchmarks/queries/clickbench/queries -o /Users/andrewlamb/Software/datafusion/benchmarks/results/bench_query_filter/clickbench_partitioned.json`
Running benchmarks with the following options: RunOpt { query: None, common: CommonOpt { iterations: 5, partitions: None, batch_size: None, mem_pool_type: "fair", memory_limit: None, sort_spill_reservation_bytes: None, debug: false }, path: "/Users/andrewlamb/Software/datafusion/benchmarks/data/hits_partitioned", queries_path: "/Users/andrewlamb/Software/datafusion/benchmarks/queries/clickbench/queries", output_path: Some("/Users/andrewlamb/Software/datafusion/benchmarks/results/bench_query_filter/clickbench_partitioned.json") }
Error: Execution("Could not open \"/Users/andrewlamb/Software/datafusion/benchmarks/queries/clickbench/queries\": No such file or directory (os error 2)")
🤔
pepijnve
commented
Jun 21, 2025
ContributorAuthor
Oh now I see what happened. I got some bench.sh changes intended for PR #16476 mixed up with this branch 🤦♂️. |
pepijnveforce-pushed
the
bench_query_filter
branch
from
June 21, 2025 13:38
8b9f844 to
a5854faCompareContributorAuthor
Just saw this was fixed on |
pepijnveforce-pushed
the
bench_query_filter
branch
from
June 24, 2025 06:32
94685af to
c8a9614Comparealamb
commented
Jun 24, 2025
Contributor
I also double checked that the commands from #16477 (review) still work. 🚀 |
alamb
commented
Jun 24, 2025
Contributor
Thanks again @pepijnve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
bench.shcurrently supports query filtering for tpch specifically. Most of the other multi query benchmarks support this too, but not viabench.sh. It would make sense to have this capability for all benchmarks that support it.What changes are included in this PR?
Promote the tpch specific logic to the top level
Are these changes tested?
Manually tested
Are there any user-facing changes?
No