Uh oh!
There was an error while loading. Please reload this page.
Minor: Add documentation to AggregateWindowExpr::get_result_column - #16479
Merged
Conversation
alamb
commented
Jun 20, 2025
Uh oh!
There was an error while loading. Please reload this page.
comphead
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #16430 I spent some time reviewing the logic and arguments and wanted to encode what I found in comments
What changes are included in this PR?
Add doc comments to
AggregateWindowExpr::get_result_columnAre these changes tested?
by CI
Are there any user-facing changes?
Just doc comments