Skip to content

Add reproducing test cases for stackoverflows - #16787

Closed
ahmed-mez wants to merge 1 commit into
apache:mainfrom
ahmed-mez:ahmed/deeply-nested-plans
Closed

Add reproducing test cases for stackoverflows#16787
ahmed-mez wants to merge 1 commit into
apache:mainfrom
ahmed-mez:ahmed/deeply-nested-plans

Conversation

@ahmed-mez

@ahmed-mezahmed-mez commented Jul 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

This is a reproducer for #16788. See the issue for more context.

What changes are included in this PR?

An ignored test case that reproduces stack-overflows

Are these changes tested?

N/A

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the substrait Changes to the substrait crate label Jul 15, 2025
@ahmed-mezahmed-mez mentioned this pull request Jul 15, 2025
Open
@ahmed-mez
ahmed-mez marked this pull request as ready for review July 15, 2025 12:38
@ahmed-mezahmed-mez mentioned this pull request Jul 15, 2025
Closed
@ahmed-mezahmed-mez changed the title Add reproducing test casesAdd reproducing test cases for stackoverflowsJul 15, 2025
@alamb

alamb commented Jul 15, 2025

Copy link
Copy Markdown
Contributor

cc @gabotechs and @LiaCastaneda

gabotechs
gabotechs approved these changes Jul 16, 2025
View reviewed changes

@gabotechsgabotechs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice reproducer!

Comment threaddatafusion/substrait/tests/cases/deeply_nested_plan.rs
const DEPTH: usize = 3000;

#[tokio::test]
#[ignore]

@gabotechsgabotechsJul 16, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment about why is it ignored?

gabotechs
gabotechs reviewed Jul 16, 2025
View reviewed changes

@gabotechsgabotechs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there could be a way of replicating this with the SQL path? something like dynamically building a deeply nested SQL statement that produces the same outcome?

There might be some value in showing the community that this is issue is not exclusive to Substrait, it might help gain some traction.

@comphead

comphead commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

I'm just wondering should it be Gist instead? 🤔

@github-actions

github-actionsBot commented Sep 17, 2025

Copy link
Copy Markdown

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actionsgithub-actionsBot added the Stale PR has not had any activity for some time label Sep 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabotechsgabotechsgabotechs approved these changes

Assignees

No one assigned

Labels

StalePR has not had any activity for some timesubstraitChanges to the substrait crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahmed-mez@alamb@comphead@gabotechs