Uh oh!
There was an error while loading. Please reload this page.
Miscellaneous cleanups - #17189
Merged
Merged
Conversation
It became redundant when `input_expr_types: &[DataType]` was replaced with `input_expr_fields: &[Field]`, i.e. in 577c424 commit. The benefit of passing in a "field" is that it combines data type and nullable attribute.
findepiforce-pushed
the
findepi/drop-redundant-param-from-windowfunctiondefinition-return-field-bdd5f7
branch
from
August 14, 2025 09:49
7c383fc to
dbf832aCompareIn `UserDefinedLogicalNode::check_invariants`, the actual plan to check for invariants is `self`. The `plan` is always `LogicalPlan::Extension` and provides no further information. It's confusing.
timsaucer
approved these changes
Aug 14, 2025
timsaucer
left a comment
Member
There was a problem hiding this comment.
These all look like very nice cleanups. Thank you for the PR!
alamb
reviewed
Aug 14, 2025
Uh oh!
There was an error while loading. Please reload this page.
| field_qualifiers: vec![None; field_count], | ||
| functional_dependencies: FunctionalDependencies::empty(), | ||
| }; | ||
| dfschema.check_names()?; |
Contributor
There was a problem hiding this comment.
Context is that checking names here makes this consistent with the other (fallible) ways to create a DFSchema from a Schema
Contributor
There was a problem hiding this comment.
FWIW it seems this has caused a regression for some users in 50.0.0 (there are some code paths that violate an invariant). See #17706
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 14, 2025
This reverts commit c31ab2e.
alamb
approved these changes
Aug 15, 2025
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @findepi and @timsaucer
Uh oh!
There was an error while loading. Please reload this page.
findepi
deleted the
findepi/drop-redundant-param-from-windowfunctiondefinition-return-field-bdd5f7
branch
August 17, 2025 06:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits