Uh oh!
There was an error while loading. Please reload this page.
Fix PartialOrd for Window - #17393
Merged
findepi merged 1 commit intoSep 4, 2025
Merged
Conversation
Before the changes, `PartialOrd` could return `Some(Equal)` for two `Window` nodes that are not equal in `PartialEq` sense. This is violation of `PartialOrd` contract. The fix is to consult eq inside ord implementation. If ord thinks two instances are equal, but they are not equal in Eq sense, they are considered incomparable.
findepiforce-pushed
the
findepi/fix-partialord-for-window-12e6f3
branch
from
September 4, 2025 10:28
94ba958 to
df03566Comparefindepi
commented
Sep 4, 2025
MemberAuthor
added a test |
timsaucer
approved these changes
Sep 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
destrex271 pushed a commit
to destrex271/datafusion
that referenced
this pull request
Sep 5, 2025
Before the changes, `PartialOrd` could return `Some(Equal)` for two `Window` nodes that are not equal in `PartialEq` sense. This is violation of `PartialOrd` contract. The fix is to consult eq inside ord implementation. If ord thinks two instances are equal, but they are not equal in Eq sense, they are considered incomparable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the changes,
PartialOrdcould returnSome(Equal)for twoWindownodes that are not equal inPartialEqsense. This is violation ofPartialOrdcontract.The fix is to consult eq inside ord implementation. If ord thinks two instances are equal, but they are not equal in Eq sense, they are considered incomparable.
PartialOrdforScalarUDF,WindowUDFandAggregateUDF#17064