Skip to content

fix: Prevent duplicate expressions in DynamicPhysicalExpr - #17551

Merged
adriangb merged 1 commit into
apache:mainfrom
UBarney:dyn_filter_dedup
Sep 16, 2025
Merged

fix: Prevent duplicate expressions in DynamicPhysicalExpr#17551
adriangb merged 1 commit into
apache:mainfrom
UBarney:dyn_filter_dedup

Conversation

@UBarney

@UBarneyUBarney commented Sep 13, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Refine report_partition_bounds Logic in shared_bounds.rs:

  • The partition parameter has been renamed to left_side_partition_id to clarify that it refers to the partition from the left (build) side.
  • New deduplication logic has been added: it skips reporting bounds if the current left_side_partition_id is identical to the previously recorded one. This directly fixes the issue in CollectLeft mode, where all streams report the same left_side_partition_id of 0, thus preventing duplicate expressions.

Are these changes tested?

Yes

Are there any user-facing changes?

No

@github-actionsgithub-actionsBot added the physical-plan Changes to the physical-plan crate label Sep 13, 2025
@github-actionsgithub-actionsBot added the core Core DataFusion crate label Sep 15, 2025
@UBarney
UBarney marked this pull request as ready for review September 16, 2025 03:49
@UBarney

Copy link
Copy Markdown
ContributorAuthor

FYI @adriangb

@adriangb
adriangb merged commit 49d49fd into apache:mainSep 16, 2025
29 checks passed
@adriangb

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratephysical-planChanges to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consumer receives duplicate bound predicates when join mode is CollectLeft

2 participants

@UBarney@adriangb