Skip to content

[branch-50] Backport Prevent exponential planning time for Window functions - v2 #17684 - #17778

Merged
alamb merged 2 commits into
apache:branch-50from
alamb:alamb/backport_planning_fix
Sep 26, 2025
Merged

[branch-50] Backport Prevent exponential planning time for Window functions - v2 #17684 #17778
alamb merged 2 commits into
apache:branch-50from
alamb:alamb/backport_planning_fix

Conversation

@alamb

@alambalamb commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

The fix for #17594 was requested for inclusion in DataFusion 50.1.0.

What changes are included in this PR?

Are these changes tested?

Yes new tests

Are there any user-facing changes?

No

@berkaysynnada@findepi@alamb
Prevent exponential planning time for Window functions - v2 (apache#1…
d22ad7e
…7684)
* fix
* Update mod.rs
* Update mod.rs
* Update mod.rs
* tests copied from v1 pr
* test case from review comment
apache#17684 (comment)
* one more test case
* Update mod.rs
* Update datafusion/physical-plan/src/windows/mod.rs
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* Update datafusion/physical-plan/src/windows/mod.rs
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* Update mod.rs
* Update mod.rs
---------
Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alambalamb changed the title [branch-50] Part of https://github.com/apache/datafusion/issues/17594[branch-50] Backport Prevent exponential planning time for Window functions - v2 #17684 Sep 25, 2025
@github-actionsgithub-actionsBot added core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) physical-plan Changes to the physical-plan crate labels Sep 25, 2025
This was referenced Sep 25, 2025
Merged
Closed
Merged
@alamb
alamb marked this pull request as ready for review September 25, 2025 18:43
@alamb

alamb commented Sep 26, 2025

Copy link
Copy Markdown
ContributorAuthor

CI Failure is due to out of disk space, which @2010YOUY01 fixed on main. I have retriggered things

@alamb

alamb commented Sep 26, 2025

Copy link
Copy Markdown
ContributorAuthor

@2010YOUY01 or @Jefffrey -- do either if you two remember what PR fixed the "out of space on device" problems on CI?

I spent a few minutes trying to find it and I couldn't despite my best github archeology skills.

This PR (backporting to branch-50) is hitting it https://github.com/apache/datafusion/actions/runs/18017424338/job/51322145417?pr=17778

rustc-LLVM ERROR: IO failure on output stream: No space left on device
error: could not compile datafusion-functions-nested (lib test)

@Jefffrey

Jefffrey commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

If it's the recent CI failures it was this one: #17677

@alamb

@alambalamb mentioned this pull request Sep 26, 2025
Merged
@alamb

alamb commented Sep 26, 2025

Copy link
Copy Markdown
ContributorAuthor

If it's the recent CI failures it was this one: #17677

@alamb

Yes, exactly that one @Jefffrey -- thank you!

I made a PR to backport that fix to the branch-50 branch too:

@alamb

alamb commented Sep 26, 2025

Copy link
Copy Markdown
ContributorAuthor

Merged up to get #17795 and hopefully it will pass CI this time

@alamb
alamb enabled auto-merge (squash) September 26, 2025 18:12
@alamb
alamb requested a review from findepiSeptember 26, 2025 18:12
@alamb
alamb merged commit 0aa2938 into apache:branch-50Sep 26, 2025
28 checks passed
@alamb
alamb deleted the alamb/backport_planning_fix branch September 26, 2025 18:47
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findepifindepifindepi approved these changes

Assignees

No one assigned

Labels

coreCore DataFusion cratephysical-planChanges to the physical-plan cratesqllogictestSQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alamb@Jefffrey@findepi@berkaysynnada