Uh oh!
There was an error while loading. Please reload this page.
Minor: reuse test schemas in simplify tests - #17864
Merged
Merged
Conversation
alamb
commented
Oct 1, 2025
| ]) | ||
| .to_dfschema_ref() | ||
| .unwrap() | ||
| static TEST_SCHEMA: LazyLock<DFSchemaRef> = LazyLock::new(|| { |
ContributorAuthor
There was a problem hiding this comment.
This just uses a static LazyLock to avoid recreating the same schemas over and over again
comphead
approved these changes
Oct 1, 2025
martin-g
approved these changes
Oct 2, 2025
alamb
commented
Oct 2, 2025
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #17835 I noticed the same schema was being made many times in the tests. While we probably can't notice a difference in performance, it would be nice to avoid this
What changes are included in this PR?
Reuse the same DFSchemaRef for the tests
Are these changes tested?
By CI
Are there any user-facing changes?