Uh oh!
There was an error while loading. Please reload this page.
chore: rename Schema print_schema_tree to tree_string - #17919
Merged
Conversation
ContributorAuthor
The method was added recently #17459 and not yet in use by users |
adriangb
reviewed
Oct 5, 2025
adriangb
left a comment
Contributor
There was a problem hiding this comment.
Since it's a public function, should we add a re-export via a deprecated method to keep backwards API compatible for a few releases? Since no parameters, etc. changed it seems easy enough to do.
adriangb
approved these changes
Oct 5, 2025
comphead
commented
Oct 5, 2025
ContributorAuthor
Thanks @adriangb it was this release added and not yet announced |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related #17466
Rationale for this change
What changes are included in this PR?
Rename
print_schema_treetotree_stringto better reflect the method purpose. The method returns a tree string, and doesn't print anythingAre these changes tested?
Yes
Are there any user-facing changes?