Uh oh!
There was an error while loading. Please reload this page.
refactor: remove core crate from datafusion-proto - #18123
Merged
Conversation
milenkovicm
approved these changes
Oct 17, 2025
milenkovicm
left a comment
Contributor
There was a problem hiding this comment.
IMHO this makes sense
thanks @timsaucer
timsaucerforce-pushed
the
refactor/remove-core-from-proto
branch
from
October 17, 2025 18:08
97031e1 to
bcea606Comparetimsaucer
marked this pull request as ready for review
October 17, 2025 18:08
alamb
commented
Oct 17, 2025
Contributor
🎉 |
Uh oh!
There was an error while loading. Please reload this page.
timsaucer
commented
Oct 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tschwarzinger pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Closesapache#17713. ## Rationale for this change Now that we have all the required supporting code moved out of the `core` crate, we can remove this as a dependency to reduce build times for downstream projects. ## What changes are included in this PR? Remove dependency. Update paths. ## Are these changes tested? Existing unit tests since this is just a code shuffle. ## Are there any user-facing changes? - Methods within the proto crate now take `TaskContext` instead of `SessionContext`
EeshanBembi pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
## Which issue does this PR close? - Closesapache#17713. ## Rationale for this change Now that we have all the required supporting code moved out of the `core` crate, we can remove this as a dependency to reduce build times for downstream projects. ## What changes are included in this PR? Remove dependency. Update paths. ## Are these changes tested? Existing unit tests since this is just a code shuffle. ## Are there any user-facing changes? - Methods within the proto crate now take `TaskContext` instead of `SessionContext`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusiondependency fromdatafusion-proto#17713.Rationale for this change
Now that we have all the required supporting code moved out of the
corecrate, we can remove this as a dependency to reduce build times for downstream projects.What changes are included in this PR?
Remove dependency.
Update paths.
Are these changes tested?
Existing unit tests since this is just a code shuffle.
Are there any user-facing changes?
TaskContextinstead ofSessionContext