Uh oh!
There was an error while loading. Please reload this page.
Use TableSchema in FileScanConfig - #18231
Merged
Merged
Conversation
adriangbforce-pushed
the
use-table-schema-filescanconfig
branch
from
October 22, 2025 20:35
a2348e5 to
212a032Compareadriangbforce-pushed
the
use-table-schema-filescanconfig
branch
from
October 22, 2025 20:37
212a032 to
52b2dd4Comparexudong963
approved these changes
Oct 24, 2025
Uh oh!
There was an error while loading. Please reload this page.
adriangb added a commit
to pydantic/datafusion
that referenced
this pull request
Oct 24, 2025
Generated by Claude
adriangb
commented
Oct 24, 2025
ContributorAuthor
Followup to add to upgrade guide: #18269 |
adriangb added a commit
to pydantic/datafusion
that referenced
this pull request
Oct 27, 2025
github-merge-queueBot
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Which issue does this PR close? - Related to #14993 ## Rationale for this change To enable expression pushdown to file sources, we need to plumb expressions through the `FileScanConfig` layer. Currently, `FileScanConfig` only tracks column indices for projection, which limits us to simple and naive column selection. This PR begins expression pushdown implementation by having `FileScanConfig` own a list of `ProjectionExpr`s, instead of column indices. This allows file sources to eventually receive and optimize based on the actual expressions being projected. ## Notes about this PR - The first commit is based off of #18231 - To avoid a super large diff and a harder review, I've decided to break (#14993) into 2 tasks: - Have the `DataSource` (`FileScanConfig`) actually hold projection expressions (this PR) - Flow the projection expressions from `DataSourceExec` all the way to the `FileSource` --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
tschwarzinger pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
tschwarzinger pushed a commit
to tschwarzinger/datafusion
that referenced
this pull request
Nov 2, 2025
## Which issue does this PR close? - Related to apache#14993 ## Rationale for this change To enable expression pushdown to file sources, we need to plumb expressions through the `FileScanConfig` layer. Currently, `FileScanConfig` only tracks column indices for projection, which limits us to simple and naive column selection. This PR begins expression pushdown implementation by having `FileScanConfig` own a list of `ProjectionExpr`s, instead of column indices. This allows file sources to eventually receive and optimize based on the actual expressions being projected. ## Notes about this PR - The first commit is based off of apache#18231 - To avoid a super large diff and a harder review, I've decided to break (apache#14993) into 2 tasks: - Have the `DataSource` (`FileScanConfig`) actually hold projection expressions (this PR) - Flow the projection expressions from `DataSourceExec` all the way to the `FileSource` --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
codetyri0n pushed a commit
to codetyri0n/datafusion
that referenced
this pull request
Nov 11, 2025
## Which issue does this PR close? - Related to apache#14993 ## Rationale for this change To enable expression pushdown to file sources, we need to plumb expressions through the `FileScanConfig` layer. Currently, `FileScanConfig` only tracks column indices for projection, which limits us to simple and naive column selection. This PR begins expression pushdown implementation by having `FileScanConfig` own a list of `ProjectionExpr`s, instead of column indices. This allows file sources to eventually receive and optimize based on the actual expressions being projected. ## Notes about this PR - The first commit is based off of apache#18231 - To avoid a super large diff and a harder review, I've decided to break (apache#14993) into 2 tasks: - Have the `DataSource` (`FileScanConfig`) actually hold projection expressions (this PR) - Flow the projection expressions from `DataSourceExec` all the way to the `FileSource` --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
EeshanBembi pushed a commit
to EeshanBembi/datafusion
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps towards #14993