Uh oh!
There was an error while loading. Please reload this page.
Minor: update ascii art example of merge - #18364
Closed
alamb wants to merge 1 commit into
Closed
Conversation
alamb
commented
Oct 29, 2025
| /// └───────────┘ └─────────┘ └─────────┘ | ||
| /// │└─────────┘│ │ 2 │ │ C │ | ||
| /// │┌─────────┐│ ├─────────┤ ├─────────┤ | ||
| /// ││ D ││ │ 2 │ │ C │ |
ContributorAuthor
There was a problem hiding this comment.
The fix is that the last entry of result should be C - not D because the last entry in indices is also 2
Contributor
There was a problem hiding this comment.
@alamb I hate to be the 'well actually' guy. The diagram was actually correct. An index n value means 'take a value from array n'. So the first 2 takes the first element from array 2 which is C. The second 2 takes the second element which is D.
The input arrays in the example were the vecs ["A"], ["B"], ["C", "D"].
ContributorAuthor
There was a problem hiding this comment.
Thank you for the clarification!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
While reviewing #18152 I think I found an issue in the example.
What changes are included in this PR?
Fix example
While i had it checked out, I also added a few OCD ascii touchups
Are these changes tested?
Are there any user-facing changes?
No, this is an update to an internal diagram. There is no behavior change