Uh oh!
There was an error while loading. Please reload this page.
Misc improvements to ProjectionExprs - #18719
Merged
Merged
Conversation
adriangbforce-pushed
the
projection-source-physexpr
branch
from
November 15, 2025 00:46
6100daf to
3f0dd4cCompareThis PR adds trait implementations, a project_batch() method, and fixes a bug in update_expr() for literal expressions. Also adds comprehensive tests. Part of apache#18627
adriangbforce-pushed
the
projection-source-physexpr
branch
from
November 15, 2025 07:00
3f0dd4c to
e0f4a8dCompareUh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
adriangb
commented
Nov 17, 2025
| /// | ||
| /// This function accepts a pre-computed output schema instead of calling [`ProjectionExprs::project_schema`] | ||
| /// so that repeated calls do not have schema projection overhead. | ||
| pub fn project_batch( |
ContributorAuthor
There was a problem hiding this comment.
Maybe a better API than this would be make_projector() -> Projector where Projector holds a reference the output schema.
ContributorAuthor
There was a problem hiding this comment.
Yep! I'm just thinking it would be less error prone to package it up in a struct. I'll push the change here then we can rebase #18627 to use the better version once this is merged.
ContributorAuthor
There was a problem hiding this comment.
The point is that users don't have to track output_schema and pass it in, they can just keep track of a Projector
ContributorAuthor
There was a problem hiding this comment.
I implemented my idea in f6afd71 and was able to use it to simplify ProjectionExec a bit so it's already used 😄
xudong963
approved these changes
Nov 18, 2025
Jefffrey
approved these changes
Nov 18, 2025
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
logan-keede pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
## Summary This PR enhances the physical-expr projection handling with several improvements needed for better projection management in datasources. ## Changes 1. **Add trait implementations**: - Added `PartialEq` and `Eq` for `ProjectionExpr` - Added `PartialEq` and `Eq` for `ProjectionExprs` 2. **Add `project_batch()` method**: - Efficiently projects `RecordBatch` with pre-computed schema - Handles empty projections correctly - Reduces schema projection overhead for repeated calls 3. **Fix `update_expr()` bug**: - **Bug**: Previously returned `None` for literal expressions (no column references) - **Fix**: Now returns `Some(expr)` for both `Unchanged` and `RewrittenValid` states - **Impact**: Critical for queries like `SELECT 1 FROM table` where no file columns are needed 4. **Change `from_indices()` signature**: - Changed from `&SchemaRef` to `&Schema` for consistency 5. **Add comprehensive tests**: - `test_merge_empty_projection_with_literal()` - Reproduces roundtrip issue - `test_update_expr_with_literal()` - Tests literal handling - `test_update_expr_with_complex_literal_expr()` - Tests mixed expressions ## Part of This PR is part of apache#18627 - a larger effort to refactor projection handling in DataFusion. ## Testing All tests pass: - ✅ New projection tests - ✅ Existing physical-expr test suite - ✅ Doc tests ## AI use I asked Claude to extract this change from apache#18627 --------- Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the physical-expr projection handling with several improvements needed for better projection management in datasources.
Changes
Add trait implementations:
PartialEqandEqforProjectionExprPartialEqandEqforProjectionExprsAdd
project_batch()method:RecordBatchwith pre-computed schemaFix
update_expr()bug:Nonefor literal expressions (no column references)Some(expr)for bothUnchangedandRewrittenValidstatesSELECT 1 FROM tablewhere no file columns are neededChange
from_indices()signature:&SchemaRefto&Schemafor consistencyAdd comprehensive tests:
test_merge_empty_projection_with_literal()- Reproduces roundtrip issuetest_update_expr_with_literal()- Tests literal handlingtest_update_expr_with_complex_literal_expr()- Tests mixed expressionsPart of
This PR is part of #18627 - a larger effort to refactor projection handling in DataFusion.
Testing
All tests pass:
AI use
I asked Claude to extract this change from #18627