Skip to content

Change CacheAccessor::remove to take &self rather than &mut self - #18726

Merged
alamb merged 4 commits into
apache:mainfrom
alchemist51:cache-interface
Nov 20, 2025
Merged

Change CacheAccessor::remove to take &self rather than &mut self#18726
alamb merged 4 commits into
apache:mainfrom
alchemist51:cache-interface

Conversation

@alchemist51

@alchemist51alchemist51 commented Nov 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

The change make the cache accessor remove API interface inline with other APIs

What changes are included in this PR?

Change the remove API for non mut type

Are these changes tested?

Covered in existing changes

Are there any user-facing changes?

The CacheAccessor trait will be slightly different now.

@alchemist51
Change cache-accessor interface
0a67190
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actionsgithub-actionsBot added the execution Related to the execution crate label Nov 15, 2025
@alchemist51

alchemist51 commented Nov 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@nuno-faria please take a look if this looks good!

nuno-faria
nuno-faria approved these changes Nov 15, 2025
View reviewed changes

@nuno-farianuno-faria left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after dealing with the clippy warnings.
It is also best to update the ticket and add that the CacheAccessor trait is now slightly different, in the "Are there any user-facing changes?" section.

@alchemist51

alchemist51 commented Nov 15, 2025

Copy link
Copy Markdown
ContributorAuthor

@nuno-faria please rerun the workflows! We can merge it post it hopefully :)

@nuno-faria

nuno-faria commented Nov 15, 2025

Copy link
Copy Markdown
Contributor

@alchemist51 unfortunately I can't. @alamb could you please run the workflows?

@alchemist51

alchemist51 commented Nov 17, 2025

Copy link
Copy Markdown
ContributorAuthor

@alamb can you please review?

@alambalamb added the api change Changes the API exposed to users of the crate label Nov 17, 2025
@alamb

alamb commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Can you perhaps also add a brief mention in the https://datafusion.apache.org/library-user-guide/upgrading.html guide for 52?

alamb
alamb approved these changes Nov 17, 2025
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nuno-faria and @alchemist51

@alambalamb changed the title Change cache-accessor interfaceChange CacheAccessor::remove to take &self rather than &mut selfNov 17, 2025
@alamb

alamb commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

@alchemist51 would this chage also close #18362?

@alchemist51

alchemist51 commented Nov 17, 2025

Copy link
Copy Markdown
ContributorAuthor

No @alamb , I'm working on a draft for it: #18401

@alchemist51

alchemist51 commented Nov 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Can you perhaps also add a brief mention in the https://datafusion.apache.org/library-user-guide/upgrading.html guide for 52?

@alamb can you please guide me to the repo/file? Will do that!

@alamb

alamb commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

Can you perhaps also add a brief mention in the https://datafusion.apache.org/library-user-guide/upgrading.html guide for 52?

@alamb can you please guide me to the repo/file? Will do that!

https://github.com/apache/datafusion/blob/main/docs/source/library-user-guide/upgrading.md

@github-actionsgithub-actionsBot added the documentation Improvements or additions to documentation label Nov 17, 2025
@alchemist51

alchemist51 commented Nov 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Updated, please check @alamb

alamb
alamb approved these changes Nov 17, 2025
View reviewed changes

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nuno-faria and @alchemist51

Comment threaddocs/source/library-user-guide/upgrading.md Outdated
@alchemist51@alamb
Update docs/source/library-user-guide/upgrading.md
886ebf5
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alchemist51

alchemist51 commented Nov 17, 2025

Copy link
Copy Markdown
ContributorAuthor

Commited the suggestion, please merge it @alamb

@alchemist51

alchemist51 commented Nov 20, 2025

Copy link
Copy Markdown
ContributorAuthor

@alamb reminder for the merge!

@alamb
alamb added this pull request to the merge queueNov 20, 2025
Merged via the queue into apache:main with commit 7d8b860Nov 20, 2025
29 checks passed
@alamb

alamb commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

Thanks for the reminder @alchemist51 -- sorry I have been backed up getting the DataFusion and Arrow releases out

@alambalamb mentioned this pull request Nov 21, 2025
Merged
logan-keede pushed a commit to logan-keede/datafusion that referenced this pull request Nov 23, 2025
@alchemist51@alamb@logan-keede
Change CacheAccessor::remove to take &self rather than &mut self (
9246b9b
apache#18726)
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closesapache#18725 ## Rationale for this change
The change make the cache accessor remove API interface inline with
other APIs
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
Change the remove API for non mut type
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
Covered in existing changes
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
The CacheAccessor trait will be slightly different now.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
---------
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nuno-farianuno-fariaAwaiting requested review from nuno-faria
@alambalambAwaiting requested review from alamb

Assignees

No one assigned

Labels

api changeChanges the API exposed to users of the cratedocumentationImprovements or additions to documentationexecutionRelated to the execution crate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change cache accessor remove interface

3 participants

@alchemist51@nuno-faria@alamb