Support "pre-image" for pruning predicate evaluation

[sdf-jkl]

Which issue does this PR close?

• ClosesSupport "pre-image" for pruning predicate evaluation #18320.

Rationale for this change

What changes are included in this PR?

Adding a new rule to expr_simplifier library - udf_preimage

This rule performs the optimization for the following operators:

• Equal
• NotEqual
• Greater
• GreaterEqual
• Less
• LessEqual
• IsDistinctFrom
• IsNotDistinctFrom

The rule currently supports optimization for date_part function given 'year' literal is passed as the interval parameter.

Are these changes tested?

Tested for all comparison operators above and all possible datatypes in unit tests and sqllogictests.

Are there any user-facing changes?

[sdf-jkl]

@alamb This works as is right now, but I like the idea of adding a new method ScalarUDFImpl::simplify_predicate() as a unified api for all scalar functions. We then can move this code in the DatePartFunc implementation of ScalarUDFImpl and create a simplification rule for scalar functions.

The rule will check if there is a scalar function is present in the predicate expression and match the corresponding ScalarUDFImpl::simplify_predicate() to simplify the expression.

[alamb]

Thanks @sdf-jkl -- this is looking quite cool

[2010YOUY01]

Thank you, this is great 👍🏼

The implementation idea looks good to me. This should be good to go after the end-to-end tests are added, and also have the test coverage double checked.

[sdf-jkl]

Hey @alamb please check when you're available!

[alamb]

Thanks -- I'll try and find some time over the next day or two

[sdf-jkl]

@alamb 👀

[sdf-jkl]

Updated IsDistinctFrom and IsNotDistinctFrom null handling logic and updated tests.

[sdf-jkl]

Hey @alamb, I've made some changes and ready for another go. Please take a look when you have time, thanks!

[alamb]

Sorry for the dealy here @sdf-jkl -- I am trying to find time to review this but I have been out and other things came up that were higher priority. I hope to return to this next week

[alamb]

(it is hard for me to find time to review 1000 line PRs, unfortunately)

[sdf-jkl]

@alamb no worries. Maybe I restructure this into some smaller PRs, so it will be easier to review?

[alamb]

@alamb no worries. Maybe I restructure this into some smaller PRs, so it will be easier to review?

That would certainly help me 🙏

[sdf-jkl]

@alamb I split it in two:

• Support API for "pre-image" for pruning predicate evaluation #19722
  preimage support logic here
• Optimize the evaluation of date_part(<col>) == <constant> when pushed down #19733
  preimage impl for data_part udf

Hope this will be helpful

[sdf-jkl]

• Support API for "pre-image" for pruning predicate evaluation #19722 supersedes this PR.