Uh oh!
There was an error while loading. Please reload this page.
reduce cloning in GuaranteeRewriter - #18823
Closed
alamb wants to merge 7 commits into
Closed
Conversation
alamb
marked this pull request as draft
November 19, 2025 15:58
This was referenced Nov 19, 2025
alamb
commented
Nov 20, 2025
ContributorAuthor
Included in #18821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
GuaranteeRewriterto datafusion_expr #18821Rationale for this change
While reviewing #18821 from @pepijnve I saw several clones I think we can avoid during the rewrite.
What changes are included in this PR?
Update the guarantee rewriter to avoid the clones
Are these changes tested?
By existing CI. I will also run benchmarks but I expect no change (
Are there any user-facing changes?