Skip to content

remove sync constraint of SendableRecordBatchStream - #1884

Merged
alamb merged 2 commits into
apache:masterfrom
doki23:master
Mar 2, 2022
Merged

remove sync constraint of SendableRecordBatchStream#1884
alamb merged 2 commits into
apache:masterfrom
doki23:master

Conversation

@doki23

@doki23doki23 commented Feb 25, 2022

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

close#1614

@alamb

alamb commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

cc @tustvold

@alambalamb added the api change Changes the API exposed to users of the crate label Mar 1, 2022

@alambalamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @doki23

@alamb

alamb commented Mar 1, 2022

Copy link
Copy Markdown
Contributor

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

@doki23

Copy link
Copy Markdown
ContributorAuthor

@doki23 I think the clippy failures have been fixed on master -- can you possible merge this branch to master (aka something like git merge apache/master so that we can get a clean CI run?

No problem

@houqphouqp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alamb

alamb commented Mar 2, 2022

Copy link
Copy Markdown
Contributor

Thanks again @doki23 !

@alamb
alamb merged commit 3c1252d into apache:masterMar 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api changeChanges the API exposed to users of the crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Sync from SendableRecordBatchStream

3 participants

@doki23@alamb@houqp