Uh oh!
There was an error while loading. Please reload this page.
wip struct field pushdown parquet - #18966
Closed
adriangb wants to merge 2 commits into
Closed
Conversation
need to figure out what to do with SchemaAdapter; there's a couple failing tests Should we do this transformation before or after ExprAdapter?
adriangb
commented
Nov 30, 2025
ContributorAuthor
I have a better next step in #18998. Essentially we migrate |
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…8998) Chips away at #14993 and #16800 Changes made in this PR: - Update DefaultPhysicalExprAdapter to handle struct column evolution - Remove use of SchemaAdapter from row filter / predicate pushdown / late materialization. I believe it was already not doing much here other than where tests checked specific behavior and had not been updated to use PhysicalExprAdapter - Changed projection handling to use `PhysicalExprAdapter` instead of `SchemaAdapter` - Kept intermediary `Vec<usize>` so we can use `ProjectionMask::roots` and punt the complexity of implementing `ProjectionExprs` -> `ProjectionMask` until a later PR (there is a draft in #18966 of what that might look like).
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step in #14993