Uh oh!
There was an error while loading. Please reload this page.
Consolidate CastColumnExpr with CastColumn - #19097
Closed
alamb wants to merge 1 commit into
Closed
Conversation
alamb
commented
Dec 4, 2025
ContributorAuthor
I need to review this code a little more but I think it is looking pretty good |
alamb
commented
Dec 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Dec 5, 2025
alambforce-pushed
the
alamb/remove_cast_column
branch
from
December 6, 2025 13:14
9fd6490 to
5ef668cComparealambforce-pushed
the
alamb/remove_cast_column
branch
from
December 9, 2025 11:24
5ef668c to
3935ba5CompareThank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
AdamGS
commented
Apr 20, 2026
Contributor
Is this still desired? Happy to help to push it through or help in any other way |
kosiew
commented
Apr 21, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
@kosiew added struct aware casting in the following PR
CastColumnExprfor struct-aware column casting #17773However, that relies on a new physical
CastColumnExprthat has a non trivial redundancy withCastExpr.Instead of relying on the new PhysicalExpr, I we should upgrade
CastExprto handle both normal and struct castingWhat changes are included in this PR?
CastColumnExprwithCastColumnCastColumnExprI had codex do the first version for me, and it did quite a nice job
Are these changes tested?
Yes by CI
Are there any user-facing changes?
No