Skip to content

Revert adding PhysicalOptimizerRule::optimize_plan - #19186

Merged
adriangb merged 3 commits into
apache:mainfrom
pydantic:revert-optimizer-api-change
Dec 8, 2025
Merged

Revert adding PhysicalOptimizerRule::optimize_plan#19186
adriangb merged 3 commits into
apache:mainfrom
pydantic:revert-optimizer-api-change

Conversation

@adriangb

@adriangbadriangb commented Dec 7, 2025

Copy link
Copy Markdown
Contributor

This reverts #18739 by reverting b990987 and 7b4593f.

Due to feedback in #18739 we've decided to revert it at least for the time being. Since this change has not been released this is not be a breaking API change.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation optimizer Optimizer rules core Core DataFusion crate execution Related to the execution crate labels Dec 7, 2025
@adriangb

Copy link
Copy Markdown
ContributorAuthor

@milenkovicm I'll wait for your approval or feedback before merging this

@adriangbadriangb changed the title Revert optimizer api changeRevert adding PhysicalOptimizerRule::optimize_planDec 8, 2025

@milenkovicmmilenkovicm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for understanding @adriangb & @gabotechs

@adriangb
adriangbforce-pushed the revert-optimizer-api-change branch from 4b62409 to c986685CompareDecember 8, 2025 15:07
@adriangb
adriangbforce-pushed the revert-optimizer-api-change branch from c986685 to 9b8ff0cCompareDecember 8, 2025 15:49
@adriangb

Copy link
Copy Markdown
ContributorAuthor

(waiting for CI to finish after rebase to merge)

@adriangb
adriangb added this pull request to the merge queueDec 8, 2025
Merged via the queue into apache:main with commit 3fabee7Dec 8, 2025
32 checks passed
rkrishn7 pushed a commit to massive-com/arrow-datafusion that referenced this pull request Jan 22, 2026
This reverts apache#18739 by
reverting b990987 and
7b4593f.
Due to feedback in apache#18739 we've
decided to revert it at least for the time being. Since this change has
not been released this is not be a breaking API change.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coreCore DataFusion cratedocumentationImprovements or additions to documentationexecutionRelated to the execution crateoptimizerOptimizer rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@adriangb@milenkovicm@gabotechs