Uh oh!
There was an error while loading. Please reload this page.
fix: inverted null_percent logic in in_list benchmark - #19204
Merged
Conversation
geoffreyclaudeforce-pushed
the
fix/in_list_benchmark
branch
from
December 8, 2025 13:45
c8a6b2c to
c5e8898Compareadriangb
approved these changes
Dec 8, 2025
adriangbforce-pushed
the
fix/in_list_benchmark
branch
from
December 8, 2025 17:39
c5e8898 to
e1e4da3CompareUh oh!
There was an error while loading. Please reload this page.
github-merge-queueBot
pushed a commit
that referenced
this pull request
Dec 8, 2025
## Which issue does this PR close? N/A - benchmark improvement Stacked on top of #19204 ## Rationale for this change We need to measure InList performance on both StringArray (Utf8) and StringViewArray (Utf8View) to compare Arrow's string representations. ## What changes are included in this PR? Add Utf8View benchmarks for InList, refactored with generics to make adding new array types trivial. ## Are these changes tested? Benchmark-only change. ## Are there any user-facing changes? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - benchmark fix discovered during performance analysis of #18832.
Rationale for this change
The
in_listbenchmark (introduced in #4068) had inverted null generation logic:null_percent=0was producing 100% nulls instead of 0% nulls.What changes are included in this PR?
Fix the
random_bool(null_percent).then(...)pattern to userandom_bool(1.0 - null_percent)so thatnull_percentcorrectly represents the percentage of null values.Are these changes tested?
Benchmark-only change. Verified by running the benchmark and observing expected performance characteristics.
Are there any user-facing changes?
No.