Enable parquet filter pushdown by default by alamb · Pull Request #19477 · apache/datafusion

alamb · 2025-12-24T10:31:37Z

Which issue does this PR close?

Rationale for this change

I am testing where we currently are with performance

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

alamb · 2025-12-24T10:31:46Z

run benchmarks

alamb-ghbot · 2025-12-24T10:31:56Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (36eae88) to 67b526adiff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

alamb-ghbot · 2025-12-24T11:11:07Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2685.93 ms │ 2651.31 ms │ no change │
│ QQuery 1 │ 1073.38 ms │ 1053.67 ms │ no change │
│ QQuery 2 │ 2088.87 ms │ 2076.62 ms │ no change │
│ QQuery 3 │ 1135.31 ms │ 1169.33 ms │ no change │
│ QQuery 4 │ 2311.12 ms │ 2333.31 ms │ no change │
│ QQuery 5 │ 28540.84 ms │ 29180.44 ms │ no change │
│ QQuery 6 │ 4022.77 ms │ 231.17 ms │ +17.40x faster │
│ QQuery 7 │ 3930.66 ms │ 4171.90 ms │ 1.06x slower │
└──────────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 45788.88ms │
│ Total Time (alamb_enable_pushdown) │ 42867.76ms │
│ Average Time (HEAD) │ 5723.61ms │
│ Average Time (alamb_enable_pushdown) │ 5358.47ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2.37 ms │ 2.13 ms │ +1.12x faster │
│ QQuery 1 │ 50.16 ms │ 52.79 ms │ 1.05x slower │
│ QQuery 2 │ 134.81 ms │ 131.30 ms │ no change │
│ QQuery 3 │ 154.45 ms │ 154.20 ms │ no change │
│ QQuery 4 │ 1137.52 ms │ 1117.24 ms │ no change │
│ QQuery 5 │ 1511.93 ms │ 1476.79 ms │ no change │
│ QQuery 6 │ 2.04 ms │ 2.02 ms │ no change │
│ QQuery 7 │ 59.58 ms │ 68.59 ms │ 1.15x slower │
│ QQuery 8 │ 1474.01 ms │ 1456.40 ms │ no change │
│ QQuery 9 │ 1854.79 ms │ 1834.23 ms │ no change │
│ QQuery 10 │ 353.18 ms │ 492.42 ms │ 1.39x slower │
│ QQuery 11 │ 402.12 ms │ 525.34 ms │ 1.31x slower │
│ QQuery 12 │ 1356.90 ms │ 1555.24 ms │ 1.15x slower │
│ QQuery 13 │ 2021.01 ms │ 2244.56 ms │ 1.11x slower │
│ QQuery 14 │ 1244.62 ms │ 1454.12 ms │ 1.17x slower │
│ QQuery 15 │ 1274.32 ms │ 1277.69 ms │ no change │
│ QQuery 16 │ 2636.20 ms │ 2571.86 ms │ no change │
│ QQuery 17 │ 2601.62 ms │ 2559.34 ms │ no change │
│ QQuery 18 │ 5918.57 ms │ 4875.16 ms │ +1.21x faster │
│ QQuery 19 │ 130.29 ms │ 141.55 ms │ 1.09x slower │
│ QQuery 20 │ 1929.33 ms │ 1857.46 ms │ no change │
│ QQuery 21 │ 2200.83 ms │ 2330.91 ms │ 1.06x slower │
│ QQuery 22 │ 3857.11 ms │ 3729.31 ms │ no change │
│ QQuery 23 │ 20156.62 ms │ 1283.72 ms │ +15.70x faster │
│ QQuery 24 │ 221.23 ms │ 283.74 ms │ 1.28x slower │
│ QQuery 25 │ 474.00 ms │ 628.50 ms │ 1.33x slower │
│ QQuery 26 │ 216.46 ms │ 340.81 ms │ 1.57x slower │
│ QQuery 27 │ 2762.90 ms │ 2961.52 ms │ 1.07x slower │
│ QQuery 28 │ 23671.71 ms │ 23963.73 ms │ no change │
│ QQuery 29 │ 970.01 ms │ 952.03 ms │ no change │
│ QQuery 30 │ 1327.99 ms │ 1342.13 ms │ no change │
│ QQuery 31 │ 1345.31 ms │ 1348.15 ms │ no change │
│ QQuery 32 │ 5652.98 ms │ 4588.56 ms │ +1.23x faster │
│ QQuery 33 │ 6275.28 ms │ 5666.71 ms │ +1.11x faster │
│ QQuery 34 │ 6526.66 ms │ 5968.31 ms │ +1.09x faster │
│ QQuery 35 │ 1983.97 ms │ 1908.53 ms │ no change │
│ QQuery 36 │ 66.42 ms │ 15.94 ms │ +4.17x faster │
│ QQuery 37 │ 45.91 ms │ 16.16 ms │ +2.84x faster │
│ QQuery 38 │ 65.21 ms │ 15.26 ms │ +4.27x faster │
│ QQuery 39 │ 105.50 ms │ 14.18 ms │ +7.44x faster │
│ QQuery 40 │ 27.96 ms │ 16.61 ms │ +1.68x faster │
│ QQuery 41 │ 22.42 ms │ 14.93 ms │ +1.50x faster │
│ QQuery 42 │ 19.97 ms │ 14.33 ms │ +1.39x faster │
└──────────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 104246.25ms │
│ Total Time (alamb_enable_pushdown) │ 83254.49ms │
│ Average Time (HEAD) │ 2424.33ms │
│ Average Time (alamb_enable_pushdown) │ 1936.15ms │
│ Queries Faster │ 13 │
│ Queries Slower │ 13 │
│ Queries with No Change │ 17 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴─────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 115.22 ms │ 114.68 ms │ no change │
│ QQuery 2 │ 29.72 ms │ 29.81 ms │ no change │
│ QQuery 3 │ 39.93 ms │ 38.86 ms │ no change │
│ QQuery 4 │ 29.27 ms │ 29.63 ms │ no change │
│ QQuery 5 │ 90.54 ms │ 89.69 ms │ no change │
│ QQuery 6 │ 19.67 ms │ 19.94 ms │ no change │
│ QQuery 7 │ 252.26 ms │ 242.01 ms │ no change │
│ QQuery 8 │ 38.03 ms │ 39.72 ms │ no change │
│ QQuery 9 │ 105.70 ms │ 103.01 ms │ no change │
│ QQuery 10 │ 63.88 ms │ 61.48 ms │ no change │
│ QQuery 11 │ 19.33 ms │ 18.03 ms │ +1.07x faster │
│ QQuery 12 │ 51.68 ms │ 53.21 ms │ no change │
│ QQuery 13 │ 47.99 ms │ 51.36 ms │ 1.07x slower │
│ QQuery 14 │ 14.31 ms │ 14.02 ms │ no change │
│ QQuery 15 │ 24.23 ms │ 24.83 ms │ no change │
│ QQuery 16 │ 24.31 ms │ 25.01 ms │ no change │
│ QQuery 17 │ 152.94 ms │ 155.39 ms │ no change │
│ QQuery 18 │ 292.03 ms │ 310.42 ms │ 1.06x slower │
│ QQuery 19 │ 37.18 ms │ 38.00 ms │ no change │
│ QQuery 20 │ 49.54 ms │ 51.51 ms │ no change │
│ QQuery 21 │ 333.15 ms │ 350.45 ms │ 1.05x slower │
│ QQuery 22 │ 17.68 ms │ 17.40 ms │ no change │
└──────────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 1848.58ms │
│ Total Time (alamb_enable_pushdown) │ 1878.46ms │
│ Average Time (HEAD) │ 84.03ms │
│ Average Time (alamb_enable_pushdown) │ 85.38ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 3 │
│ Queries with No Change │ 18 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

adriangb · 2025-12-25T15:59:49Z

What a 🎄 🎁 ! I see mostly speedups, vastly outweighing the slowdowns, but there are still slowdowns... any idea what those cases have in common? Any way I can help brainstorm solutions?

alamb · 2025-12-27T12:09:57Z

What a 🎄 🎁 ! I see mostly speedups, vastly outweighing the slowdowns, but there are still slowdowns... any idea what those cases have in common? Any way I can help brainstorm solutions?

Thanks @adriangb -- I am not working full time the next few days but I am hoping to work on this particular item as it is something I desparately want to be done with (and I find it fun!)

I spent some time analyzing where the time is going. I haven't written up my notes yet, but I will do so (probably tomorrow as I have a long train ride).

I found a few places to improve, but nothing that will obviously get back all the time (yet). I'll kep at it

# Which issue does this PR close? - RElated to apache/datafusion#19477 # Rationale for this change While profiling apache/datafusion#19477 I noticed some additional clones we could avoid <img width="1504" height="927" alt="Screenshot 2025-12-26 at 12 03 00 PM" src="https://github.com/user-attachments/assets/958f76e2-53d0-4008-b224-d9275984cd1a" /> I doubt this will be a huge deal but it does remove some allocations int he parquet read path # What changes are included in this PR? Use `into_data` rather than `to_data` # Are these changes tested?  # Are there any user-facing changes?

alamb · 2025-12-29T12:55:05Z

I also wrote up some notes about current status and plan here:

Enable parquet filter pushdown (filter_pushdown) by default #3463 (comment)

Dandandan · 2026-01-03T12:52:54Z

run benchmark tpch

alamb-ghbot · 2026-01-03T12:53:00Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (36eae88) to 67b526adiff using: tpch
Results will be posted here when complete

Dandandan · 2026-01-03T12:53:04Z

run benchmark tpcds

alamb-ghbot · 2026-01-03T13:09:04Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 190.82 ms │ 199.11 ms │ no change │
│ QQuery 2 │ 93.77 ms │ 128.85 ms │ 1.37x slower │
│ QQuery 3 │ 125.10 ms │ 192.31 ms │ 1.54x slower │
│ QQuery 4 │ 75.03 ms │ 124.79 ms │ 1.66x slower │
│ QQuery 5 │ 165.04 ms │ 342.06 ms │ 2.07x slower │
│ QQuery 6 │ 66.31 ms │ 107.95 ms │ 1.63x slower │
│ QQuery 7 │ 208.69 ms │ 250.14 ms │ 1.20x slower │
│ QQuery 8 │ 164.10 ms │ 279.78 ms │ 1.70x slower │
│ QQuery 9 │ 222.55 ms │ 389.32 ms │ 1.75x slower │
│ QQuery 10 │ 179.97 ms │ 267.35 ms │ 1.49x slower │
│ QQuery 11 │ 72.19 ms │ 102.21 ms │ 1.42x slower │
│ QQuery 12 │ 116.14 ms │ 258.92 ms │ 2.23x slower │
│ QQuery 13 │ 213.12 ms │ 209.43 ms │ no change │
│ QQuery 14 │ 92.02 ms │ 102.09 ms │ 1.11x slower │
│ QQuery 15 │ 119.53 ms │ 167.51 ms │ 1.40x slower │
│ QQuery 16 │ 56.09 ms │ 89.96 ms │ 1.60x slower │
│ QQuery 17 │ 263.36 ms │ 278.76 ms │ 1.06x slower │
│ QQuery 18 │ 313.29 ms │ 660.48 ms │ 2.11x slower │
│ QQuery 19 │ 132.03 ms │ 169.52 ms │ 1.28x slower │
│ QQuery 20 │ 124.02 ms │ 147.16 ms │ 1.19x slower │
│ QQuery 21 │ 253.64 ms │ 308.28 ms │ 1.22x slower │
│ QQuery 22 │ 43.38 ms │ 65.67 ms │ 1.51x slower │
└──────────────┴───────────┴───────────────────────┴──────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3290.19ms │
│ Total Time (alamb_enable_pushdown) │ 4841.65ms │
│ Average Time (HEAD) │ 149.55ms │
│ Average Time (alamb_enable_pushdown) │ 220.07ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 20 │
│ Queries with No Change │ 2 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

alamb-ghbot · 2026-01-03T13:09:07Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (36eae88) to 67b526adiff using: tpcds
Results will be posted here when complete

alamb-ghbot · 2026-01-03T13:09:08Z

Benchmark script failed with exit code 1.

Last 10 lines of output:

Click to expand

BRANCH_NAME: HEAD
DATA_DIR: /home/alamb/arrow-datafusion/benchmarks/data
RESULTS_DIR: /home/alamb/arrow-datafusion/benchmarks/results/HEAD
CARGO_COMMAND: cargo run --release
PREFER_HASH_JOIN: true
***************************
Please prepare TPC-DS data first by following instructions:
./bench.sh data tpcds

Dandandan · 2026-01-03T14:17:00Z

--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ QQuery 1 │ 190.82 ms │ 199.11 ms │ no change │
│ QQuery 2 │ 93.77 ms │ 128.85 ms │ 1.37x slower │
│ QQuery 3 │ 125.10 ms │ 192.31 ms │ 1.54x slower │
│ QQuery 4 │ 75.03 ms │ 124.79 ms │ 1.66x slower │
│ QQuery 5 │ 165.04 ms │ 342.06 ms │ 2.07x slower │
│ QQuery 6 │ 66.31 ms │ 107.95 ms │ 1.63x slower │
│ QQuery 7 │ 208.69 ms │ 250.14 ms │ 1.20x slower │
│ QQuery 8 │ 164.10 ms │ 279.78 ms │ 1.70x slower │
│ QQuery 9 │ 222.55 ms │ 389.32 ms │ 1.75x slower │
│ QQuery 10 │ 179.97 ms │ 267.35 ms │ 1.49x slower │
│ QQuery 11 │ 72.19 ms │ 102.21 ms │ 1.42x slower │
│ QQuery 12 │ 116.14 ms │ 258.92 ms │ 2.23x slower │
│ QQuery 13 │ 213.12 ms │ 209.43 ms │ no change │
│ QQuery 14 │ 92.02 ms │ 102.09 ms │ 1.11x slower │
│ QQuery 15 │ 119.53 ms │ 167.51 ms │ 1.40x slower │
│ QQuery 16 │ 56.09 ms │ 89.96 ms │ 1.60x slower │
│ QQuery 17 │ 263.36 ms │ 278.76 ms │ 1.06x slower │
│ QQuery 18 │ 313.29 ms │ 660.48 ms │ 2.11x slower │
│ QQuery 19 │ 132.03 ms │ 169.52 ms │ 1.28x slower │
│ QQuery 20 │ 124.02 ms │ 147.16 ms │ 1.19x slower │
│ QQuery 21 │ 253.64 ms │ 308.28 ms │ 1.22x slower │
│ QQuery 22 │ 43.38 ms │ 65.67 ms │ 1.51x slower │
└──────────────┴───────────┴───────────────────────┴──────────────┘

This doesn't look great....

Dandandan · 2026-01-03T14:17:21Z

run benchmark tpch

alamb-ghbot · 2026-01-03T14:52:14Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (36eae88) to 67b526adiff using: tpch
Results will be posted here when complete

alamb-ghbot · 2026-01-03T15:07:11Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 192.60 ms │ 197.88 ms │ no change │
│ QQuery 2 │ 92.74 ms │ 129.40 ms │ 1.40x slower │
│ QQuery 3 │ 122.64 ms │ 198.28 ms │ 1.62x slower │
│ QQuery 4 │ 74.81 ms │ 132.29 ms │ 1.77x slower │
│ QQuery 5 │ 172.26 ms │ 342.66 ms │ 1.99x slower │
│ QQuery 6 │ 66.49 ms │ 106.20 ms │ 1.60x slower │
│ QQuery 7 │ 214.54 ms │ 258.79 ms │ 1.21x slower │
│ QQuery 8 │ 159.64 ms │ 268.68 ms │ 1.68x slower │
│ QQuery 9 │ 222.34 ms │ 395.58 ms │ 1.78x slower │
│ QQuery 10 │ 186.05 ms │ 272.04 ms │ 1.46x slower │
│ QQuery 11 │ 74.56 ms │ 100.83 ms │ 1.35x slower │
│ QQuery 12 │ 116.72 ms │ 250.88 ms │ 2.15x slower │
│ QQuery 13 │ 222.65 ms │ 203.76 ms │ +1.09x faster │
│ QQuery 14 │ 92.91 ms │ 100.57 ms │ 1.08x slower │
│ QQuery 15 │ 118.71 ms │ 170.82 ms │ 1.44x slower │
│ QQuery 16 │ 54.74 ms │ 86.85 ms │ 1.59x slower │
│ QQuery 17 │ 267.10 ms │ 283.58 ms │ 1.06x slower │
│ QQuery 18 │ 314.15 ms │ 658.08 ms │ 2.09x slower │
│ QQuery 19 │ 134.45 ms │ 169.76 ms │ 1.26x slower │
│ QQuery 20 │ 126.26 ms │ 145.27 ms │ 1.15x slower │
│ QQuery 21 │ 259.83 ms │ 310.24 ms │ 1.19x slower │
│ QQuery 22 │ 42.69 ms │ 65.44 ms │ 1.53x slower │
└──────────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3328.90ms │
│ Total Time (alamb_enable_pushdown) │ 4847.86ms │
│ Average Time (HEAD) │ 151.31ms │
│ Average Time (alamb_enable_pushdown) │ 220.36ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 20 │
│ Queries with No Change │ 1 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

@hhhizzz

# Which issue does this PR close?  - related to apache/datafusion#19477 # Rationale for this change While working on apache/datafusion#19477, and profiling ClickBench q7, I noticed that the RowSelectors was being cloned to resolve the strategy -- for a large number of selections this is expensive and shows up in the traces <img width="1724" height="1074" alt="Screenshot 2025-12-28 at 4 49 49 PM" src="https://github.com/user-attachments/assets/72c6fd22-9377-48ef-ba80-6bc03b177cf7" /> ```shell samply record -- ./datafusion-cli-alamb_enable_pushdown -f q.sql > /dev/null 2>& ``` We should change the code to avoid cloning the RowSelectors when resolving the strategy. # Changes Don't clone / allocate while resolving the strategy. I don't expect this to have a massive impact, but it did show up in the profile FYI @hhhizzz -- perhaps you could review this PR # Are these changes tested? Yes by CI # Are there any user-facing changes? small performance improvement

# Which issue does this PR close? - related to apache/datafusion#19477 # Rationale for this change I am tracking down allocations in various parts of the parquet reader (to remove them) and I ran across this in the cached reader. # What changes are included in this PR? Use `Arc::clone` to make it clear there is no deep cloning going on . I don't expect this will have any impact on actual performance # Are these changes tested? By CI # Are there any user-facing changes?

alamb-ghbot · 2026-02-03T17:11:45Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2285.58 ms │ 2307.52 ms │ no change │
│ QQuery 1 │ 899.02 ms │ 918.81 ms │ no change │
│ QQuery 2 │ 1777.72 ms │ 1795.99 ms │ no change │
│ QQuery 3 │ 1042.60 ms │ 1119.15 ms │ 1.07x slower │
│ QQuery 4 │ 2171.04 ms │ 2220.51 ms │ no change │
│ QQuery 5 │ 28096.18 ms │ 28320.96 ms │ no change │
│ QQuery 6 │ 3962.17 ms │ 221.21 ms │ +17.91x faster │
│ QQuery 7 │ 2712.48 ms │ 2656.65 ms │ no change │
└──────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 42946.80ms │
│ Total Time (alamb_enable_pushdown) │ 39560.80ms │
│ Average Time (HEAD) │ 5368.35ms │
│ Average Time (alamb_enable_pushdown) │ 4945.10ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2.67 ms │ 2.69 ms │ no change │
│ QQuery 1 │ 52.13 ms │ 51.49 ms │ no change │
│ QQuery 2 │ 136.18 ms │ 133.32 ms │ no change │
│ QQuery 3 │ 158.67 ms │ 156.92 ms │ no change │
│ QQuery 4 │ 1055.35 ms │ 1019.65 ms │ no change │
│ QQuery 5 │ 1289.82 ms │ 1264.84 ms │ no change │
│ QQuery 6 │ 6.60 ms │ 37.10 ms │ 5.62x slower │
│ QQuery 7 │ 55.00 ms │ 66.90 ms │ 1.22x slower │
│ QQuery 8 │ 1395.58 ms │ 1403.20 ms │ no change │
│ QQuery 9 │ 1790.47 ms │ 1773.47 ms │ no change │
│ QQuery 10 │ 346.36 ms │ 470.32 ms │ 1.36x slower │
│ QQuery 11 │ 400.16 ms │ 512.58 ms │ 1.28x slower │
│ QQuery 12 │ 1206.94 ms │ 1387.55 ms │ 1.15x slower │
│ QQuery 13 │ 1916.11 ms │ 2047.68 ms │ 1.07x slower │
│ QQuery 14 │ 1248.57 ms │ 1395.72 ms │ 1.12x slower │
│ QQuery 15 │ 1205.43 ms │ 1154.08 ms │ no change │
│ QQuery 16 │ 2515.10 ms │ 2430.63 ms │ no change │
│ QQuery 17 │ 2454.83 ms │ 2423.86 ms │ no change │
│ QQuery 18 │ 5177.31 ms │ 5093.72 ms │ no change │
│ QQuery 19 │ 124.48 ms │ 140.69 ms │ 1.13x slower │
│ QQuery 20 │ 1957.89 ms │ 1883.21 ms │ no change │
│ QQuery 21 │ 2245.40 ms │ 2375.61 ms │ 1.06x slower │
│ QQuery 22 │ 3813.68 ms │ 3792.06 ms │ no change │
│ QQuery 23 │ 17024.84 ms │ 1269.49 ms │ +13.41x faster │
│ QQuery 24 │ 214.03 ms │ 293.30 ms │ 1.37x slower │
│ QQuery 25 │ 464.67 ms │ 613.04 ms │ 1.32x slower │
│ QQuery 26 │ 211.14 ms │ 316.88 ms │ 1.50x slower │
│ QQuery 27 │ 2651.97 ms │ 2858.53 ms │ 1.08x slower │
│ QQuery 28 │ 22125.30 ms │ 22156.70 ms │ no change │
│ QQuery 29 │ 995.70 ms │ 988.84 ms │ no change │
│ QQuery 30 │ 1287.54 ms │ 1278.71 ms │ no change │
│ QQuery 31 │ 1320.35 ms │ 1303.69 ms │ no change │
│ QQuery 32 │ 4849.06 ms │ 4048.55 ms │ +1.20x faster │
│ QQuery 33 │ 5526.05 ms │ 5126.18 ms │ +1.08x faster │
│ QQuery 34 │ 6188.85 ms │ 5892.32 ms │ no change │
│ QQuery 35 │ 1926.73 ms │ 1835.97 ms │ no change │
│ QQuery 36 │ 193.86 ms │ 175.57 ms │ +1.10x faster │
│ QQuery 37 │ 71.58 ms │ 85.14 ms │ 1.19x slower │
│ QQuery 38 │ 116.75 ms │ 87.70 ms │ +1.33x faster │
│ QQuery 39 │ 336.26 ms │ 280.53 ms │ +1.20x faster │
│ QQuery 40 │ 38.67 ms │ 48.84 ms │ 1.26x slower │
│ QQuery 41 │ 34.91 ms │ 42.16 ms │ 1.21x slower │
│ QQuery 42 │ 30.78 ms │ 33.69 ms │ 1.09x slower │
└───────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 96163.76ms │
│ Total Time (alamb_enable_pushdown) │ 79753.12ms │
│ Average Time (HEAD) │ 2236.37ms │
│ Average Time (alamb_enable_pushdown) │ 1854.72ms │
│ Queries Faster │ 6 │
│ Queries Slower │ 17 │
│ Queries with No Change │ 20 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 101.05 ms │ 103.49 ms │ no change │
│ QQuery 2 │ 32.79 ms │ 32.88 ms │ no change │
│ QQuery 3 │ 36.28 ms │ 40.90 ms │ 1.13x slower │
│ QQuery 4 │ 30.95 ms │ 30.91 ms │ no change │
│ QQuery 5 │ 90.46 ms │ 92.76 ms │ no change │
│ QQuery 6 │ 28.37 ms │ 21.16 ms │ +1.34x faster │
│ QQuery 7 │ 162.93 ms │ 157.39 ms │ no change │
│ QQuery 8 │ 41.92 ms │ 39.86 ms │ no change │
│ QQuery 9 │ 104.06 ms │ 106.77 ms │ no change │
│ QQuery 10 │ 67.73 ms │ 67.41 ms │ no change │
│ QQuery 11 │ 18.65 ms │ 18.74 ms │ no change │
│ QQuery 12 │ 52.20 ms │ 52.24 ms │ no change │
│ QQuery 13 │ 49.03 ms │ 49.67 ms │ no change │
│ QQuery 14 │ 15.24 ms │ 15.26 ms │ no change │
│ QQuery 15 │ 31.27 ms │ 30.84 ms │ no change │
│ QQuery 16 │ 29.33 ms │ 28.79 ms │ no change │
│ QQuery 17 │ 147.14 ms │ 145.52 ms │ no change │
│ QQuery 18 │ 282.80 ms │ 290.94 ms │ no change │
│ QQuery 19 │ 39.32 ms │ 39.55 ms │ no change │
│ QQuery 20 │ 56.10 ms │ 56.54 ms │ no change │
│ QQuery 21 │ 193.24 ms │ 191.84 ms │ no change │
│ QQuery 22 │ 22.78 ms │ 22.16 ms │ no change │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 1633.64ms │
│ Total Time (alamb_enable_pushdown) │ 1635.65ms │
│ Average Time (HEAD) │ 74.26ms │
│ Average Time (alamb_enable_pushdown) │ 74.35ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 20 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

alamb-ghbot · 2026-02-03T17:11:51Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (0be1135) to 81f7a87diff using: tpch
Results will be posted here when complete

alamb-ghbot · 2026-02-03T17:12:31Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 177.51 ms │ 186.72 ms │ 1.05x slower │
│ QQuery 2 │ 86.08 ms │ 88.98 ms │ no change │
│ QQuery 3 │ 123.83 ms │ 162.19 ms │ 1.31x slower │
│ QQuery 4 │ 79.16 ms │ 122.80 ms │ 1.55x slower │
│ QQuery 5 │ 168.84 ms │ 200.35 ms │ 1.19x slower │
│ QQuery 6 │ 70.44 ms │ 99.43 ms │ 1.41x slower │
│ QQuery 7 │ 212.78 ms │ 233.35 ms │ 1.10x slower │
│ QQuery 8 │ 161.64 ms │ 211.35 ms │ 1.31x slower │
│ QQuery 9 │ 229.01 ms │ 242.54 ms │ 1.06x slower │
│ QQuery 10 │ 185.08 ms │ 232.81 ms │ 1.26x slower │
│ QQuery 11 │ 60.95 ms │ 57.86 ms │ +1.05x faster │
│ QQuery 12 │ 116.71 ms │ 186.04 ms │ 1.59x slower │
│ QQuery 13 │ 220.82 ms │ 212.53 ms │ no change │
│ QQuery 14 │ 85.13 ms │ 98.44 ms │ 1.16x slower │
│ QQuery 15 │ 120.39 ms │ 173.80 ms │ 1.44x slower │
│ QQuery 16 │ 57.79 ms │ 67.74 ms │ 1.17x slower │
│ QQuery 17 │ 254.29 ms │ 254.58 ms │ no change │
│ QQuery 18 │ 304.95 ms │ 310.58 ms │ no change │
│ QQuery 19 │ 131.86 ms │ 195.83 ms │ 1.49x slower │
│ QQuery 20 │ 126.67 ms │ 143.29 ms │ 1.13x slower │
│ QQuery 21 │ 250.04 ms │ 318.80 ms │ 1.27x slower │
│ QQuery 22 │ 41.67 ms │ 65.63 ms │ 1.57x slower │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3265.65ms │
│ Total Time (alamb_enable_pushdown) │ 3865.65ms │
│ Average Time (HEAD) │ 148.44ms │
│ Average Time (alamb_enable_pushdown) │ 175.71ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 17 │
│ Queries with No Change │ 4 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

Changed default value of enable_aggregate_dynamic_filter_pushdown from false to true.

Dandandan · 2026-02-03T17:26:38Z

run benchmark tpch

alamb-ghbot · 2026-02-03T17:26:45Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (48ba0d8) to 81f7a87diff using: tpch
Results will be posted here when complete

Dandandan · 2026-02-03T17:40:14Z

run benchmark tpch

alamb-ghbot · 2026-02-03T17:40:47Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 177.51 ms │ 184.31 ms │ no change │
│ QQuery 2 │ 85.19 ms │ 88.30 ms │ no change │
│ QQuery 3 │ 121.06 ms │ 163.14 ms │ 1.35x slower │
│ QQuery 4 │ 77.72 ms │ 121.95 ms │ 1.57x slower │
│ QQuery 5 │ 172.27 ms │ 203.42 ms │ 1.18x slower │
│ QQuery 6 │ 66.29 ms │ 100.27 ms │ 1.51x slower │
│ QQuery 7 │ 202.25 ms │ 229.44 ms │ 1.13x slower │
│ QQuery 8 │ 160.13 ms │ 209.98 ms │ 1.31x slower │
│ QQuery 9 │ 227.10 ms │ 237.79 ms │ no change │
│ QQuery 10 │ 184.16 ms │ 230.60 ms │ 1.25x slower │
│ QQuery 11 │ 59.80 ms │ 58.40 ms │ no change │
│ QQuery 12 │ 119.11 ms │ 176.25 ms │ 1.48x slower │
│ QQuery 13 │ 226.96 ms │ 211.27 ms │ +1.07x faster │
│ QQuery 14 │ 90.15 ms │ 94.69 ms │ 1.05x slower │
│ QQuery 15 │ 125.16 ms │ 172.80 ms │ 1.38x slower │
│ QQuery 16 │ 58.61 ms │ 68.00 ms │ 1.16x slower │
│ QQuery 17 │ 254.05 ms │ 254.28 ms │ no change │
│ QQuery 18 │ 306.37 ms │ 305.70 ms │ no change │
│ QQuery 19 │ 131.79 ms │ 192.36 ms │ 1.46x slower │
│ QQuery 20 │ 128.99 ms │ 144.60 ms │ 1.12x slower │
│ QQuery 21 │ 251.35 ms │ 328.14 ms │ 1.31x slower │
│ QQuery 22 │ 42.23 ms │ 64.00 ms │ 1.52x slower │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3268.24ms │
│ Total Time (alamb_enable_pushdown) │ 3839.69ms │
│ Average Time (HEAD) │ 148.56ms │
│ Average Time (alamb_enable_pushdown) │ 174.53ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 15 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

alamb-ghbot · 2026-02-03T17:40:50Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (9aab98e) to 81f7a87diff using: tpch
Results will be posted here when complete

alamb-ghbot · 2026-02-03T17:54:55Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 179.30 ms │ 187.97 ms │ no change │
│ QQuery 2 │ 86.49 ms │ 82.19 ms │ no change │
│ QQuery 3 │ 123.44 ms │ 158.93 ms │ 1.29x slower │
│ QQuery 4 │ 76.07 ms │ 124.79 ms │ 1.64x slower │
│ QQuery 5 │ 166.01 ms │ 201.29 ms │ 1.21x slower │
│ QQuery 6 │ 60.92 ms │ 106.57 ms │ 1.75x slower │
│ QQuery 7 │ 205.11 ms │ 226.57 ms │ 1.10x slower │
│ QQuery 8 │ 163.96 ms │ 208.14 ms │ 1.27x slower │
│ QQuery 9 │ 224.89 ms │ 221.43 ms │ no change │
│ QQuery 10 │ 184.34 ms │ 236.52 ms │ 1.28x slower │
│ QQuery 11 │ 60.92 ms │ 58.66 ms │ no change │
│ QQuery 12 │ 118.95 ms │ 179.30 ms │ 1.51x slower │
│ QQuery 13 │ 227.13 ms │ 207.56 ms │ +1.09x faster │
│ QQuery 14 │ 87.20 ms │ 95.60 ms │ 1.10x slower │
│ QQuery 15 │ 120.03 ms │ 170.81 ms │ 1.42x slower │
│ QQuery 16 │ 60.34 ms │ 68.94 ms │ 1.14x slower │
│ QQuery 17 │ 261.63 ms │ 256.85 ms │ no change │
│ QQuery 18 │ 306.86 ms │ 307.93 ms │ no change │
│ QQuery 19 │ 132.49 ms │ 191.26 ms │ 1.44x slower │
│ QQuery 20 │ 125.13 ms │ 146.82 ms │ 1.17x slower │
│ QQuery 21 │ 254.11 ms │ 317.91 ms │ 1.25x slower │
│ QQuery 22 │ 39.23 ms │ 46.21 ms │ 1.18x slower │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3264.54ms │
│ Total Time (alamb_enable_pushdown) │ 3802.25ms │
│ Average Time (HEAD) │ 148.39ms │
│ Average Time (alamb_enable_pushdown) │ 172.83ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 15 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

Dandandan · 2026-02-03T18:13:33Z

Run benchmarks

alamb-ghbot · 2026-02-03T18:13:37Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (9aab98e) to 81f7a87diff using: tpch_mem clickbench_partitioned clickbench_extended
Results will be posted here when complete

alamb-ghbot · 2026-02-03T18:37:13Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark clickbench_extended.json
--------------------
┏━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2297.25 ms │ 2259.86 ms │ no change │
│ QQuery 1 │ 880.68 ms │ 871.70 ms │ no change │
│ QQuery 2 │ 1853.13 ms │ 1803.56 ms │ no change │
│ QQuery 3 │ 1067.59 ms │ 1048.81 ms │ no change │
│ QQuery 4 │ 2170.73 ms │ 2232.07 ms │ no change │
│ QQuery 5 │ 27783.17 ms │ 28484.08 ms │ no change │
│ QQuery 6 │ 3933.50 ms │ 228.38 ms │ +17.22x faster │
│ QQuery 7 │ 2677.46 ms │ 2647.61 ms │ no change │
└──────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 42663.51ms │
│ Total Time (alamb_enable_pushdown) │ 39576.07ms │
│ Average Time (HEAD) │ 5332.94ms │
│ Average Time (alamb_enable_pushdown) │ 4947.01ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 7 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark clickbench_partitioned.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ QQuery 0 │ 2.62 ms │ 2.64 ms │ no change │
│ QQuery 1 │ 49.51 ms │ 51.47 ms │ no change │
│ QQuery 2 │ 133.32 ms │ 133.76 ms │ no change │
│ QQuery 3 │ 156.67 ms │ 154.70 ms │ no change │
│ QQuery 4 │ 1028.47 ms │ 1020.52 ms │ no change │
│ QQuery 5 │ 1268.32 ms │ 1262.87 ms │ no change │
│ QQuery 6 │ 6.97 ms │ 18.31 ms │ 2.63x slower │
│ QQuery 7 │ 56.43 ms │ 66.17 ms │ 1.17x slower │
│ QQuery 8 │ 1347.06 ms │ 1390.74 ms │ no change │
│ QQuery 9 │ 1797.98 ms │ 1759.60 ms │ no change │
│ QQuery 10 │ 345.41 ms │ 468.99 ms │ 1.36x slower │
│ QQuery 11 │ 392.04 ms │ 518.41 ms │ 1.32x slower │
│ QQuery 12 │ 1176.58 ms │ 1351.86 ms │ 1.15x slower │
│ QQuery 13 │ 1809.61 ms │ 2027.79 ms │ 1.12x slower │
│ QQuery 14 │ 1186.74 ms │ 1398.84 ms │ 1.18x slower │
│ QQuery 15 │ 1168.72 ms │ 1170.80 ms │ no change │
│ QQuery 16 │ 2424.58 ms │ 2440.80 ms │ no change │
│ QQuery 17 │ 2371.46 ms │ 2408.41 ms │ no change │
│ QQuery 18 │ 5056.48 ms │ 4990.94 ms │ no change │
│ QQuery 19 │ 121.17 ms │ 136.08 ms │ 1.12x slower │
│ QQuery 20 │ 1940.24 ms │ 1866.94 ms │ no change │
│ QQuery 21 │ 2175.96 ms │ 2326.98 ms │ 1.07x slower │
│ QQuery 22 │ 3722.49 ms │ 3799.05 ms │ no change │
│ QQuery 23 │ 22380.43 ms │ 1262.86 ms │ +17.72x faster │
│ QQuery 24 │ 225.45 ms │ 286.19 ms │ 1.27x slower │
│ QQuery 25 │ 492.85 ms │ 610.96 ms │ 1.24x slower │
│ QQuery 26 │ 214.29 ms │ 331.85 ms │ 1.55x slower │
│ QQuery 27 │ 2591.61 ms │ 2896.79 ms │ 1.12x slower │
│ QQuery 28 │ 22044.35 ms │ 22172.53 ms │ no change │
│ QQuery 29 │ 981.62 ms │ 942.92 ms │ no change │
│ QQuery 30 │ 1246.89 ms │ 1245.34 ms │ no change │
│ QQuery 31 │ 1313.28 ms │ 1299.35 ms │ no change │
│ QQuery 32 │ 4311.21 ms │ 3888.52 ms │ +1.11x faster │
│ QQuery 33 │ 5450.79 ms │ 5146.00 ms │ +1.06x faster │
│ QQuery 34 │ 5686.57 ms │ 5506.89 ms │ no change │
│ QQuery 35 │ 1848.94 ms │ 1841.42 ms │ no change │
│ QQuery 36 │ 190.92 ms │ 173.62 ms │ +1.10x faster │
│ QQuery 37 │ 73.00 ms │ 85.74 ms │ 1.17x slower │
│ QQuery 38 │ 115.96 ms │ 90.33 ms │ +1.28x faster │
│ QQuery 39 │ 352.58 ms │ 288.64 ms │ +1.22x faster │
│ QQuery 40 │ 39.16 ms │ 48.88 ms │ 1.25x slower │
│ QQuery 41 │ 34.84 ms │ 44.14 ms │ 1.27x slower │
│ QQuery 42 │ 30.35 ms │ 33.44 ms │ 1.10x slower │
└───────────┴─────────────┴───────────────────────┴────────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩
│ Total Time (HEAD) │ 99363.94ms │
│ Total Time (alamb_enable_pushdown) │ 78963.13ms │
│ Average Time (HEAD) │ 2310.79ms │
│ Average Time (alamb_enable_pushdown) │ 1836.35ms │
│ Queries Faster │ 6 │
│ Queries Slower │ 17 │
│ Queries with No Change │ 20 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴────────────┘
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1 │ 103.27 ms │ 101.26 ms │ no change │
│ QQuery 2 │ 32.17 ms │ 33.15 ms │ no change │
│ QQuery 3 │ 41.57 ms │ 39.77 ms │ no change │
│ QQuery 4 │ 30.44 ms │ 30.39 ms │ no change │
│ QQuery 5 │ 89.47 ms │ 89.29 ms │ no change │
│ QQuery 6 │ 21.03 ms │ 21.37 ms │ no change │
│ QQuery 7 │ 159.12 ms │ 162.68 ms │ no change │
│ QQuery 8 │ 40.25 ms │ 41.16 ms │ no change │
│ QQuery 9 │ 104.99 ms │ 108.72 ms │ no change │
│ QQuery 10 │ 68.19 ms │ 68.47 ms │ no change │
│ QQuery 11 │ 18.89 ms │ 19.27 ms │ no change │
│ QQuery 12 │ 52.06 ms │ 52.06 ms │ no change │
│ QQuery 13 │ 47.26 ms │ 48.34 ms │ no change │
│ QQuery 14 │ 15.56 ms │ 14.91 ms │ no change │
│ QQuery 15 │ 31.19 ms │ 31.37 ms │ no change │
│ QQuery 16 │ 28.67 ms │ 28.17 ms │ no change │
│ QQuery 17 │ 146.01 ms │ 142.93 ms │ no change │
│ QQuery 18 │ 287.49 ms │ 288.87 ms │ no change │
│ QQuery 19 │ 39.84 ms │ 40.09 ms │ no change │
│ QQuery 20 │ 58.16 ms │ 58.79 ms │ no change │
│ QQuery 21 │ 198.02 ms │ 193.59 ms │ no change │
│ QQuery 22 │ 23.18 ms │ 23.93 ms │ no change │
└───────────┴───────────┴───────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 1636.84ms │
│ Total Time (alamb_enable_pushdown) │ 1638.57ms │
│ Average Time (HEAD) │ 74.40ms │
│ Average Time (alamb_enable_pushdown) │ 74.48ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 22 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

alamb · 2026-02-12T14:19:30Z

(note there is no longer any regression with the tpch benchmarks 🎉 )

adriangb · 2026-02-12T14:45:31Z

 /// When set to true, the optimizer will attempt to push down Join dynamic filters
 /// into the file scan phase.
- pub enable_join_dynamic_filter_pushdown: bool, default = true
+ pub enable_join_dynamic_filter_pushdown: bool, default = false


I say ship it! We can work on re-enabling this later 😄

Dandandan · 2026-02-12T17:31:48Z

(note there is no longer any regression with the tpch benchmarks 🎉 )

Huh, there still seems to be, no? :

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 179.30 ms │ 187.97 ms │ no change │
│ QQuery 2 │ 86.49 ms │ 82.19 ms │ no change │
│ QQuery 3 │ 123.44 ms │ 158.93 ms │ 1.29x slower │
│ QQuery 4 │ 76.07 ms │ 124.79 ms │ 1.64x slower │
│ QQuery 5 │ 166.01 ms │ 201.29 ms │ 1.21x slower │
│ QQuery 6 │ 60.92 ms │ 106.57 ms │ 1.75x slower │
│ QQuery 7 │ 205.11 ms │ 226.57 ms │ 1.10x slower │
│ QQuery 8 │ 163.96 ms │ 208.14 ms │ 1.27x slower │
│ QQuery 9 │ 224.89 ms │ 221.43 ms │ no change │
│ QQuery 10 │ 184.34 ms │ 236.52 ms │ 1.28x slower │
│ QQuery 11 │ 60.92 ms │ 58.66 ms │ no change │
│ QQuery 12 │ 118.95 ms │ 179.30 ms │ 1.51x slower │
│ QQuery 13 │ 227.13 ms │ 207.56 ms │ +1.09x faster │
│ QQuery 14 │ 87.20 ms │ 95.60 ms │ 1.10x slower │
│ QQuery 15 │ 120.03 ms │ 170.81 ms │ 1.42x slower │
│ QQuery 16 │ 60.34 ms │ 68.94 ms │ 1.14x slower │
│ QQuery 17 │ 261.63 ms │ 256.85 ms │ no change │
│ QQuery 18 │ 306.86 ms │ 307.93 ms │ no change │
│ QQuery 19 │ 132.49 ms │ 191.26 ms │ 1.44x slower │
│ QQuery 20 │ 125.13 ms │ 146.82 ms │ 1.17x slower │
│ QQuery 21 │ 254.11 ms │ 317.91 ms │ 1.25x slower │
│ QQuery 22 │ 39.23 ms │ 46.21 ms │ 1.18x slower │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3264.54ms │
│ Total Time (alamb_enable_pushdown) │ 3802.25ms │
│ Average Time (HEAD) │ 148.39ms │
│ Average Time (alamb_enable_pushdown) │ 172.83ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 15 │
│ Queries with No Change │ 6 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

alamb · 2026-02-12T20:53:32Z

Huh, there still seems to be, no? :

🤔 there wans't on some previous run 🤔

alamb · 2026-02-12T20:54:01Z

run benchmark tpch_mem

alamb-ghbot · 2026-02-12T23:01:54Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (9aab98e) to 81f7a87diff using: tpch_mem
Results will be posted here when complete

alamb-ghbot · 2026-02-12T23:17:22Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ QQuery 1 │ 104.70 ms │ 104.83 ms │ no change │
│ QQuery 2 │ 33.00 ms │ 31.92 ms │ no change │
│ QQuery 3 │ 40.80 ms │ 41.49 ms │ no change │
│ QQuery 4 │ 30.79 ms │ 31.44 ms │ no change │
│ QQuery 5 │ 91.60 ms │ 93.51 ms │ no change │
│ QQuery 6 │ 21.68 ms │ 21.89 ms │ no change │
│ QQuery 7 │ 158.86 ms │ 164.39 ms │ no change │
│ QQuery 8 │ 38.39 ms │ 40.11 ms │ no change │
│ QQuery 9 │ 106.36 ms │ 107.31 ms │ no change │
│ QQuery 10 │ 68.32 ms │ 69.71 ms │ no change │
│ QQuery 11 │ 18.84 ms │ 19.21 ms │ no change │
│ QQuery 12 │ 51.98 ms │ 52.15 ms │ no change │
│ QQuery 13 │ 49.79 ms │ 48.27 ms │ no change │
│ QQuery 14 │ 15.81 ms │ 15.61 ms │ no change │
│ QQuery 15 │ 31.42 ms │ 30.81 ms │ no change │
│ QQuery 16 │ 28.78 ms │ 28.89 ms │ no change │
│ QQuery 17 │ 144.11 ms │ 146.75 ms │ no change │
│ QQuery 18 │ 283.92 ms │ 284.75 ms │ no change │
│ QQuery 19 │ 40.61 ms │ 40.16 ms │ no change │
│ QQuery 20 │ 56.10 ms │ 56.49 ms │ no change │
│ QQuery 21 │ 191.23 ms │ 199.77 ms │ no change │
│ QQuery 22 │ 23.18 ms │ 23.13 ms │ no change │
└───────────┴───────────┴───────────────────────┴───────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 1630.28ms │
│ Total Time (alamb_enable_pushdown) │ 1652.62ms │
│ Average Time (HEAD) │ 74.10ms │
│ Average Time (alamb_enable_pushdown) │ 75.12ms │
│ Queries Faster │ 0 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 22 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

Dandandan · 2026-02-13T13:16:46Z

run benchmark tpch

alamb-ghbot · 2026-02-13T13:16:49Z

🤖 ./gh_compare_branch.shgh_compare_branch.sh Running
Linux aal-dev 6.14.0-1018-gcp #19~24.04.1-Ubuntu SMP Wed Sep 24 23:23:09 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Comparing alamb/enable_pushdown (9aab98e) to 81f7a87diff using: tpch
Results will be posted here when complete

Dandandan · 2026-02-13T13:18:04Z

Huh, there still seems to be, no? :
🤔 there wans't on some previous run 🤔

tpch_mem doesn't have filter pushdown ;)
The tpch (from parquet) and tpcds still have huge slowdowns due to join filters.

alamb-ghbot · 2026-02-13T13:32:31Z

🤖: Benchmark completed

Details

Comparing HEAD and alamb_enable_pushdown
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ HEAD ┃ alamb_enable_pushdown ┃ Change ┃
┡━━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 196.90 ms │ 186.24 ms │ +1.06x faster │
│ QQuery 2 │ 102.16 ms │ 85.79 ms │ +1.19x faster │
│ QQuery 3 │ 129.43 ms │ 164.98 ms │ 1.27x slower │
│ QQuery 4 │ 78.60 ms │ 130.37 ms │ 1.66x slower │
│ QQuery 5 │ 174.07 ms │ 201.16 ms │ 1.16x slower │
│ QQuery 6 │ 61.21 ms │ 101.33 ms │ 1.66x slower │
│ QQuery 7 │ 204.25 ms │ 226.80 ms │ 1.11x slower │
│ QQuery 8 │ 166.43 ms │ 206.55 ms │ 1.24x slower │
│ QQuery 9 │ 226.39 ms │ 222.24 ms │ no change │
│ QQuery 10 │ 189.26 ms │ 236.00 ms │ 1.25x slower │
│ QQuery 11 │ 60.60 ms │ 58.83 ms │ no change │
│ QQuery 12 │ 117.67 ms │ 178.66 ms │ 1.52x slower │
│ QQuery 13 │ 224.63 ms │ 211.29 ms │ +1.06x faster │
│ QQuery 14 │ 94.34 ms │ 98.08 ms │ no change │
│ QQuery 15 │ 126.55 ms │ 172.34 ms │ 1.36x slower │
│ QQuery 16 │ 60.51 ms │ 73.35 ms │ 1.21x slower │
│ QQuery 17 │ 265.63 ms │ 259.32 ms │ no change │
│ QQuery 18 │ 308.32 ms │ 307.21 ms │ no change │
│ QQuery 19 │ 129.35 ms │ 197.41 ms │ 1.53x slower │
│ QQuery 20 │ 126.83 ms │ 145.35 ms │ 1.15x slower │
│ QQuery 21 │ 258.76 ms │ 317.91 ms │ 1.23x slower │
│ QQuery 22 │ 42.13 ms │ 46.62 ms │ 1.11x slower │
└───────────┴───────────┴───────────────────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (HEAD) │ 3344.02ms │
│ Total Time (alamb_enable_pushdown) │ 3827.83ms │
│ Average Time (HEAD) │ 152.00ms │
│ Average Time (alamb_enable_pushdown) │ 173.99ms │
│ Queries Faster │ 3 │
│ Queries Slower │ 14 │
│ Queries with No Change │ 5 │
│ Queries with Failure │ 0 │
└──────────────────────────────────────┴───────────┘

github-actions · 2026-04-29T02:17:24Z

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

Enable pushdown by defauly
36eae88

github-actionsBot added the common Related to common crate label Dec 24, 2025

adriangb mentioned this pull request Dec 25, 2025
Redesign the try_reverse_output to support more cases #19446
Merged

alamb mentioned this pull request Dec 26, 2025
Minor: avoid some clones when reading parquet apache/arrow-rs#9048
Merged

alamb mentioned this pull request Dec 29, 2025
Reduce overhead to create an Array from ArrayData (make_array) apache/arrow-rs#9061
Closed

adriangb mentioned this pull request Jan 2, 2026
perf: optimize HashTableLookupExpr::evaluate#19602
Merged

alamb mentioned this pull request Jan 8, 2026
TEST: enable pushdown_filters by default #18874
Closed

Set enable_aggregate_dynamic_filter_pushdown default to true
48ba0d8
Changed default value of enable_aggregate_dynamic_filter_pushdown from false to true.

Decrease minimum file size for repartitioning
9aab98e

alamb mentioned this pull request Feb 7, 2026
[TESTING] Test parquet filter pushdown with mask backed row selection #19301
Closed

alamb mentioned this pull request Feb 12, 2026
(testing) Enable parquet filter pushdown by default + arrow/parquet 58 #20318
Closed

adriangb reviewed Feb 12, 2026
View reviewed changes

github-actionsBot added the Stale PR has not had any activity for some time label Apr 29, 2026

github-actionsBot closed this May 7, 2026

Uh oh!

Conversation

alamb commented Dec 24, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

alamb commented Dec 24, 2025

Uh oh!

alamb-ghbot commented Dec 24, 2025

Uh oh!

alamb-ghbot commented Dec 24, 2025

Uh oh!

adriangb commented Dec 25, 2025

Uh oh!

alamb commented Dec 27, 2025

Uh oh!

alamb commented Dec 29, 2025

Uh oh!

Dandandan commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

Dandandan commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

Dandandan commented Jan 3, 2026

Uh oh!

Dandandan commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Jan 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

Dandandan commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

Dandandan commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

Dandandan commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb-ghbot commented Feb 3, 2026

Uh oh!

alamb commented Feb 12, 2026

Uh oh!

adriangbFeb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Dandandan commented Feb 12, 2026

Uh oh!

alamb commented Feb 12, 2026

Uh oh!

alamb commented Feb 12, 2026

Uh oh!

alamb-ghbot commented Feb 12, 2026

Uh oh!

alamb-ghbot commented Feb 12, 2026

alamb commented Dec 24, 2025•
edited
Loading

Dandandan commented Feb 13, 2026•
edited
Loading