Skip to content

[branch-52] Fix Internal error: Assertion failed: !self.finished: LimitedBatchCoalescer (#19785) - #19836

Merged
alamb merged 1 commit into
apache:branch-52from
alamb:alamb/backport_filter_fix
Jan 16, 2026
Merged

[branch-52] Fix Internal error: Assertion failed: !self.finished: LimitedBatchCoalescer (#19785)#19836
alamb merged 1 commit into
apache:branch-52from
alamb:alamb/backport_filter_fix

Conversation

@alamb

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Backport a regression found by @bert-beyondloops into the 52 release line

What changes are included in this PR?

Backport fix for #19781, #19785 to branch-52

Are these changes tested?

Yes

Are there any user-facing changes?

bug fix

…edBatchCoalescer (apache#19785)
## Which issue does this PR close?
PR will close issue apache#19781.
## Rationale for this change
Fixes the internal error
## What changes are included in this PR?
The code change is inspired by the `CoalesceBatchesStream`
implementation.
## Are these changes tested?
Additional sqllogictest written in limit.slt which triggered the issue
before the fix.
## Are there any user-facing changes?
No
---------
Co-authored-by: Bert Vermeiren <bert.vermeiren@datadobi.com>
@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation development-process Related to development process of DataFusion physical-expr Changes to the physical-expr crates core Core DataFusion crate sqllogictest SQL Logic Tests (.slt) catalog Related to the catalog crate execution Related to the execution crate datasource Changes to the datasource crate physical-plan Changes to the physical-plan crate labels Jan 15, 2026
@alamb
alamb changed the base branch from main to branch-52January 15, 2026 18:52
@alambalamb changed the title Alamb/backport filter fix[branch-52] Fix Internal error: Assertion failed: !self.finished: LimitedBatchCoalescer (#19785)Jan 15, 2026
@alamb
alamb merged commit 18fdd8b into apache:branch-52Jan 16, 2026
2 of 3 checks passed
@alamb

Copy link
Copy Markdown
ContributorAuthor

Thank you @xudong963

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

catalogRelated to the catalog cratecoreCore DataFusion cratedatasourceChanges to the datasource cratedevelopment-processRelated to development process of DataFusiondocumentationImprovements or additions to documentationexecutionRelated to the execution cratephysical-exprChanges to the physical-expr cratesphysical-planChanges to the physical-plan cratesqllogictestSQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@alamb@xudong963@bert-beyondloops