Uh oh!
There was an error while loading. Please reload this page.
Fix incorrect SortExec removal before AggregateExec - #20245
Closed
alamb wants to merge 1 commit into
Closed
Conversation
alambforce-pushed
the
alamb/fix_monotonic_sort_bug
branch
from
February 9, 2026 19:57
70f8863 to
91df46fComparealamb
commented
Feb 9, 2026
| } | ||
| } else if maintains_input_order.is_empty() | ||
| || !maintains_input_order.iter().any(|o| *o) | ||
| // Aggregate output columns can be computed expressions that are not |
ContributorAuthor
There was a problem hiding this comment.
This is a pretty large hammer (just disables pushing grouping requirements through all AggregateExec`s convinced this is the best solution / correct yet
SortExec removal before AggregateExecalamb
commented
Feb 10, 2026
ContributorAuthor
I am convinced we should go with option 2
|
github-merge-queueBot
pushed a commit
that referenced
this pull request
Feb 16, 2026
…20247) ## Which issue does this PR close? - Fixes#20244 This is an alternatative to - #20245 ## Rationale for this change Wrong answers bug was exposed by #19287 in 52. See #20244 and backstory here - #19287 (comment) ## What changes are included in this PR? Fix the bug by properly implemnting ## Are these changes tested? Yes, a new test is added ## Are there any user-facing changes? A bug is fixed --------- Co-authored-by: Mustafa Akur <akurmustafa@gmail.com>
alamb added a commit
to alamb/datafusion
that referenced
this pull request
Feb 23, 2026
…pache#20247) - Fixesapache#20244 This is an alternatative to - apache#20245 Wrong answers bug was exposed by apache#19287 in 52. See apache#20244 and backstory here - apache#19287 (comment) Fix the bug by properly implemnting Yes, a new test is added A bug is fixed --------- Co-authored-by: Mustafa Akur <akurmustafa@gmail.com>
alamb added a commit
to alamb/datafusion
that referenced
this pull request
Feb 23, 2026
…pache#20247) - Fixesapache#20244 This is an alternatative to - apache#20245 Wrong answers bug was exposed by apache#19287 in 52. See apache#20244 and backstory here - apache#19287 (comment) Fix the bug by properly implemnting Yes, a new test is added A bug is fixed --------- Co-authored-by: Mustafa Akur <akurmustafa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Wrong answers bug was introduced in 52
What changes are included in this PR?
Fix the bug with a big hammer: simply disable the whole optimizatio
Here is an alternative PR to just disable it in a more targeted setting
SortExecremoval beforeAggregateExec(option 2) #20247Are these changes tested?
Yes, a new test is added
Are there any user-facing changes?
A bug is fixed