Uh oh!
There was an error while loading. Please reload this page.
Update comments on OptimizerRule about function name matching - #20346
Merged
Conversation
alambforce-pushed
the
alamb/documentation
branch
from
February 13, 2026 19:59
2137f99 to
6071a18Compareneilconway
approved these changes
Feb 13, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Feb 13, 2026
alamb
left a comment
ContributorAuthor
There was a problem hiding this comment.
Thanks @neilconway -- I did the changes in 6759858
alamb
marked this pull request as ready for review
February 13, 2026 20:27
2010YOUY01
approved these changes
Feb 23, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the doc. I believe this is a pretty important detail to know!
| /// ## Matching on functions | ||
| /// | ||
| /// The rule should avoid function-specific transformations, and instead use | ||
| /// methods on [`ScalarUDFImpl`] and [`AggregateUDFImpl`]. Specifically, the |
Contributor
There was a problem hiding this comment.
I remember there are still several cases that rely on function name checking, where it is not possible to implement the optimization using methods on ScalarUDFImpl.
We have a tracking issue, should we link it here? #18643
github-merge-queueBot
pushed a commit
that referenced
this pull request
Feb 23, 2026
## Which issue does this PR close? - Similarly to #20346 ## Rationale for this change As part of PR reviews, it seems like it is not obvious to some contributors that there is a non trivial cost to adding new optimizer rules. Let's add that knowledge into the codebase as comments, so it may be less of a surprise ## What changes are included in this PR? Add comments ## Are these changes tested? N/A ## Are there any user-facing changes? No this is entirely internal comments oly --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
de-bgunter pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…20348) ## Which issue does this PR close? - Similarly to apache#20346 ## Rationale for this change As part of PR reviews, it seems like it is not obvious to some contributors that there is a non trivial cost to adding new optimizer rules. Let's add that knowledge into the codebase as comments, so it may be less of a surprise ## What changes are included in this PR? Add comments ## Are these changes tested? N/A ## Are there any user-facing changes? No this is entirely internal comments oly --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
de-bgunter pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…#20346) ## Which issue does this PR close? - Related to apache#20180 ## Rationale for this change I gave feedback to @devanshu0987https://github.com/apache/datafusion/pull/20180/changes#r2800720037 that it was not a good idea to check for function names in optimizer rules, but then I realized that the rationale for this is not written down anywhere. ## What changes are included in this PR? Document why checking for function names in optimizer rules is not good and offer alternatives ## Are these changes tested? By CI ## Are there any user-facing changes? Just docs, no functional changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
I gave feedback to @devanshu0987https://github.com/apache/datafusion/pull/20180/changes#r2800720037 that it was not a good idea to check for function names in optimizer rules, but then I realized that the rationale for this is not written down anywhere.
What changes are included in this PR?
Document why checking for function names in optimizer rules is not good and offer alternatives
Are these changes tested?
By CI
Are there any user-facing changes?
Just docs, no functional changes