Uh oh!
There was an error while loading. Please reload this page.
fix: use try_shrink instead of shrink in try_resize - #20424
Merged
Conversation
xanderbailey
commented
Feb 25, 2026
Contributor
Do you have an example of when shrink fails in this case? |
ariel-miculas
commented
Feb 25, 2026
ContributorAuthor
I don't have any example of when this can happen, it's just that shrink |
xanderbailey
approved these changes
Feb 25, 2026
Uh oh!
There was an error while loading. Please reload this page.
26 tasks
alamb pushed a commit
to alamb/datafusion
that referenced
this pull request
Mar 12, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closesapache#123` indicates that this PR will close issue apache#123. --> No issue ## Rationale for this change The `try_` functions should return errors instead of panicking. ## What changes are included in this PR? use `try_shrink` instead of `shrink` ## Are these changes tested? No, `try_shrink` is already tested. ## Are there any user-facing changes? No
comphead pushed a commit
that referenced
this pull request
Mar 12, 2026
…) (#20890) - Part of #19692 This PR: - Backports #20424 from @ariel-miculas to the branch-53 line Co-authored-by: Ariel Miculas-Trif <ariel.miculas@gmail.com>
de-bgunter pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closesapache#123` indicates that this PR will close issue apache#123. --> No issue ## Rationale for this change The `try_` functions should return errors instead of panicking. ## What changes are included in this PR? use `try_shrink` instead of `shrink` ## Are these changes tested? No, `try_shrink` is already tested. ## Are there any user-facing changes? No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue
Rationale for this change
The
try_functions should return errors instead of panicking.What changes are included in this PR?
use
try_shrinkinstead ofshrinkAre these changes tested?
No,
try_shrinkis already tested.Are there any user-facing changes?
No