feat: spark compatible ceil function - #20703
Closed
coderfender wants to merge 6 commits into
Closed
Conversation
Contributor
Author
|
@martin-g please review whenever you get a chance. Thank you |
coderfender
force-pushed
the
df_spark_ceil
branch
3 times, most recently
from
March 4, 2026 22:34
f65f61e to
6132f42
Compare
coderfender
force-pushed
the
df_spark_ceil
branch
from
March 4, 2026 22:38
6132f42 to
251883f
Compare
Contributor
|
Thanks @coderfender btw there is another PR for |
Contributor
Author
|
@comphead , sure please take a look at the PR whenever you get a chance. |
Contributor
Author
|
@martin-g , requesting review to port ceil function from comet to spark |
coderfender
force-pushed
the
df_spark_ceil
branch
from
March 10, 2026 07:52
a713e57 to
6f67673
Compare
coderfender
force-pushed
the
df_spark_ceil
branch
from
March 10, 2026 08:14
6f67673 to
b5102ec
Compare
Contributor
Author
|
Closed since #20593 is merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
ceilfunction to datafusion-sparkWhat changes are included in this PR?
SparkCeilUDF supporting Float32/64, Int8/16/32/64, and Decimal128precision, scale -> precision - scale + 1, 0)Are these changes tested?
Are there any user-facing changes?