Uh oh!
There was an error while loading. Please reload this page.
Improve documentation for AggregateUdfImpl::simplify and WindowUDFImpl::simplify - #20712
Merged
Conversation
alambforce-pushed
the
alamb/better_simplity_docs
branch
from
March 4, 2026 23:53
50f2d88 to
1626cf7CompareAggregateUdfImpl::simplifyAggregateUdfImpl::simplify and WindowUDFImpl::simplifyalamb
marked this pull request as ready for review
March 4, 2026 23:54
2010YOUY01
approved these changes
Mar 5, 2026
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you, great doc improvement 👍🏼
Uh oh!
There was an error while loading. Please reload this page.
4 tasks
Co-authored-by: Yongting You <2010youy01@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
alamb
commented
Mar 5, 2026
ContributorAuthor
Thanks @2010YOUY01 and @comphead |
de-bgunter pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
…Impl::simplify` (apache#20712) ## Rationale for this change While working on apache#20665 I was somewhat confused about how the AggregateUDF simplify worked. So I added some more clarifying comments ## What changes are included in this PR? 1. Improve documentation strings ## Are these changes tested? Yes by CI ## Are there any user-facing changes? Better API docs --------- Co-authored-by: Yongting You <2010youy01@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While working on #20665 I was somewhat confused about how the AggregateUDF simplify worked. So I added some more clarifying comments
What changes are included in this PR?
Are these changes tested?
Yes by CI
Are there any user-facing changes?
Better API docs