Uh oh!
There was an error while loading. Please reload this page.
perf: Optimize comparison on nested types - #20716
Merged
Merged
Conversation
neilconway
commented
Mar 5, 2026
ContributorAuthor
Benchmarks: |
alamb
reviewed
Mar 5, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me -- thanks @neilconway
I do wonder why we can't update collect to call collect_bool internally 🤔
alamb
approved these changes
Mar 5, 2026
neilconway
commented
Mar 15, 2026
ContributorAuthor
@alamb Is this good to land? Let me know if you have any suggestions! |
alamb
commented
Mar 16, 2026
Contributor
Sorry @neilconway -- it looks good to me -- it got lost in the shuffle. I updated once more to rerun the tests and will merge once those pass |
alamb
commented
Mar 16, 2026
Contributor
Thanks again @neilconway |
Uh oh!
There was an error while loading. Please reload this page.
de-bgunter pushed a commit
to de-bgunter/datafusion
that referenced
this pull request
Mar 24, 2026
## Which issue does this PR close? N/A ## Rationale for this change `BooleanBuffer::collect_bool()` is faster than `map().collect()`. Per discussion on apache#20694; originally suggested by @Dandandan. ## What changes are included in this PR? - Implement optimization - Add benchmark for nested struct comparison ## Are these changes tested? Yes, covered by existing tests. ## Are there any user-facing changes? No. ## AI usage Multiple AI tools were used to iterate on this PR. I have reviewed and understand the resulting code. --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
BooleanBuffer::collect_bool()is faster thanmap().collect(). Per discussion on #20694; originally suggested by @Dandandan.What changes are included in this PR?
Are these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
No.
AI usage
Multiple AI tools were used to iterate on this PR. I have reviewed and understand the resulting code.