Skip to content

ser/de fetch in FilterExec - #20738

Merged
jonahgao merged 3 commits into
apache:mainfrom
haohuaijin:ser/de-fetch
Mar 8, 2026
Merged

ser/de fetch in FilterExec#20738
jonahgao merged 3 commits into
apache:mainfrom
haohuaijin:ser/de-fetch

Conversation

@haohuaijin

@haohuaijinhaohuaijin commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

FilterExec have fetch filed but not impl the ser/de in proto

What changes are included in this PR?

add ser/de for fetch in FilterExec

Are these changes tested?

add one test case

Are there any user-facing changes?

@github-actionsgithub-actionsBot added proto Related to proto crate physical-plan Changes to the physical-plan crate labels Mar 6, 2026
@haohuaijinhaohuaijin reopened this Mar 6, 2026

@jonahgaojonahgao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahgao
jonahgao added this pull request to the merge queueMar 8, 2026
Merged via the queue into apache:main with commit 4dbb449Mar 8, 2026
38 of 67 checks passed
@haohuaijin
haohuaijin deleted the ser/de-fetch branch March 8, 2026 13:16
alamb pushed a commit to alamb/datafusion that referenced this pull request Mar 11, 2026
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closesapache#20737
## Rationale for this change
FilterExec have fetch filed but not impl the ser/de in proto
## What changes are included in this PR?
add ser/de for fetch in FilterExec
## Are these changes tested?
add one test case
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
alamb added a commit that referenced this pull request Mar 12, 2026
- Part of #19692
- Closes#20737 on branch-53
This PR:
- Backports #20738 from
@haohuaijin to the branch-53 line
Co-authored-by: Huaijin <haohuaijin@gmail.com>
de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closesapache#20737
## Rationale for this change
FilterExec have fetch filed but not impl the ser/de in proto
## What changes are included in this PR?
add ser/de for fetch in FilterExec
## Are these changes tested?
add one test case
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-planChanges to the physical-plan crateprotoRelated to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FilterExec's fetch not impl the ser/de in protobuf

3 participants

@haohuaijin@hengfeiyang@jonahgao