Enable debug assertions in CI.

[stuhood]

Which issue does this PR close?

• ClosesDebug assertions currently failing on main #20831.

Rationale for this change

CI uses release profiles to allow tests to run more quickly (and potentially also to provide more coverage for the most realistic case for end users of the system). But debug assertions can expose real bugs / mistaken assumptions, and so they should be covered in CI as well.

What changes are included in this PR?

Adjust the Rust build profiles which are used in CI to enable debug assertions.

Are these changes tested?

Yes, by CI.

Are there any user-facing changes?

No.

[alamb]

if we go this route we should also leave some breadcrumbs in the code to know when we can revert the changes too

It might make more sense to just fix the upstream bug

[stuhood]

if we go this route we should also leave some breadcrumbs in the code to know when we can revert the changes too

It might make more sense to just fix the upstream bug

I believe that we want to enable this regardless of the upstream bug fixes, because this is about preventing further debug-assertion-failures from landing.

[mbutrovich]

+1 from me, I just raised this issue with @andygrove on Comet today when we are adding debug_assert around some code and I commented that "we don't run that in CI anyway."

I love debug_assert sprinkle them everywhere! Thanks @stuhood. It should already be enabled for [profile.ci] though, right? I don't mind it being explicit, just curious.

[stuhood]

This did not fail because sqllogictest-sqlite did not run for some reason: likely because .github/workflows/labeler/labeler-config.yml will not match for the edits that have been made.

But this PR will/should fail until the arrow upgrade fix for #20689 is actually merged.

[stuhood]

It should already be enabled for [profile.ci] though, right? I don't mind it being explicit, just curious.

Yea, it looks like you are right: https://doc.rust-lang.org/cargo/reference/profiles.html#dev

I'm happy to remove it, or to leave it explicit.

[2010YOUY01]

It should already be enabled for [profile.ci] though, right? I don't mind it being explicit, just curious.

Yea, it looks like you are right: https://doc.rust-lang.org/cargo/reference/profiles.html#dev

I'm happy to remove it, or to leave it explicit.

Now most rust tests is running in --profile ci, however this new --profile ci-release profile looks more reasonable to me 🤔 . Maybe their compilation time is longer then running time, so --profile ci makes CI faster? If someone can confirm this, we can add the explanation to

datafusion/Cargo.toml

Line 230 in 86cb815

# Profiles available:

However, for the extended SQLite test suite (which includes many test cases), the workload should be dominated by test execution time rather than compilation time, so this ci-release profile is likely necessary.

[stuhood]

With #21044 in, this should now be unblocked: I've rebased it.

@alamb, @mbutrovich: mind taking another look?

[mbutrovich]

Approved pending CI. Thanks @stuhood!