Skip to content

chore: Remove usage of paste crate - #20946

Merged
comphead merged 5 commits into
apache:mainfrom
coderfender:deprecate_paste_module
Mar 16, 2026
Merged

chore: Remove usage of paste crate#20946
comphead merged 5 commits into
apache:mainfrom
coderfender:deprecate_paste_module

Conversation

@coderfender

@coderfendercoderfender commented Mar 14, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actionsgithub-actionsBot added sql SQL Planner logical-expr Logical plan and expressions physical-expr Changes to the physical-expr crates core Core DataFusion crate functions Changes to functions implementation labels Mar 14, 2026
@coderfender

coderfender commented Mar 14, 2026

Copy link
Copy Markdown
ContributorAuthor

TODO : Deprecate paste crate usage in error.rs

@github-actionsgithub-actionsBot added the common Related to common crate label Mar 14, 2026
@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from d3b8705 to 3fd56d0CompareMarch 14, 2026 17:12
@coderfender
coderfender marked this pull request as ready for review March 14, 2026 17:12
@coderfendercoderfender changed the title chore : deprecate_paste_cratechore: deprecate_paste_crateMar 14, 2026
@coderfender

coderfender commented Mar 14, 2026

Copy link
Copy Markdown
ContributorAuthor

@martin-g , ready for your review

@coderfender

coderfender commented Mar 14, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@comphead , I took the more laborious approach to remove paste crate and replace the macro defs with elaborated arguments than trying to find a new crate. Almost all other past crate usage is in tests / non critical path of code with one major usage in UDWF and Error macros

@coderfendercoderfender changed the title chore: deprecate_paste_cratechore: Deprecate usage of paste crateMar 14, 2026
@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from 3fd56d0 to 1e54eebCompareMarch 14, 2026 17:50
@coderfender

coderfender commented Mar 14, 2026

Copy link
Copy Markdown
ContributorAuthor

Fixed a typo simple_udfw instead of simple_udwf

martin-g
martin-g reviewed Mar 15, 2026
View reviewed changes
Comment threaddatafusion/functions-window/src/cume_dist.rs Outdated
Comment threaddatafusion/functions-window/src/lib.rs Outdated
Comment threaddatafusion/functions-window/src/macros.rs Outdated
Comment threaddatafusion/functions-table/src/lib.rs
Comment threaddatafusion/common/src/error.rs Outdated
Comment threaddatafusion/functions-window/src/macros.rs Outdated
Comment threaddatafusion/functions-window/src/macros.rs
Comment threaddatafusion/functions-window/src/macros.rs
Comment threaddatafusion/functions-window/src/macros.rs
Comment threaddatafusion/functions-window/src/macros.rs
@coderfender

coderfender commented Mar 15, 2026

Copy link
Copy Markdown
ContributorAuthor

Thank you for the review @martin-g . Fixed the typo with udfw in the docs aignature and fixed macro signature docs per review comments. Take a look whenever you get a chance . Thank you

@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from 6137d6f to 15c04c3CompareMarch 16, 2026 03:24
@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from 15c04c3 to 3b893edCompareMarch 16, 2026 03:55
@comphead

comphead commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

we would also need to rollback #20850

@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from 8b77322 to b4812a8CompareMarch 16, 2026 18:55
@github-actionsgithub-actionsBot added the development-process Related to development process of DataFusion label Mar 16, 2026
@coderfender

coderfender commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

@comphead , thank you for the review. I was wondering if we could do it in a different PR but I believe we can do it in the current PR too. I just pushed a commit to unignore the rust warning in git wf. Please take a look whenever you get a chance

@coderfender
coderfenderforce-pushed the deprecate_paste_module branch from 13dad74 to 12dbdebCompareMarch 16, 2026 19:02
@alambalamb changed the title chore: Deprecate usage of paste cratechore: Remove usage of paste crateMar 16, 2026
@alamb

alamb commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

this looks great -- thank you @coderfender and @martin-g.

@coderfender

coderfender commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

Thank you @alamb

comphead
comphead reviewed Mar 16, 2026
View reviewed changes
Comment threaddatafusion/common/src/error.rs
comphead
comphead reviewed Mar 16, 2026
View reviewed changes
Comment threaddatafusion/common/src/error.rs Outdated
comphead
comphead approved these changes Mar 16, 2026
View reviewed changes

@compheadcomphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coderfender this is LGTM
PTAL on comments explaining why underscore variants are needed

@coderfender

coderfender commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

Let me address the comments @comphead

@coderfender

coderfender commented Mar 16, 2026

Copy link
Copy Markdown
ContributorAuthor

@comphead , done . I added the comments in macro def per your review

@comphead

comphead commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Thanks @coderfender and @martin-g

@comphead
comphead added this pull request to the merge queueMar 16, 2026
Merged via the queue into apache:main with commit 5d37babMar 16, 2026
37 checks passed
@compheadcomphead mentioned this pull request Mar 16, 2026
Closed
de-bgunter pushed a commit to de-bgunter/datafusion that referenced this pull request Mar 24, 2026
@coderfender@de-bgunter
chore: Remove usage ofpastecrate (apache#20946)
4457690
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closesapache#123` indicates that this PR will close issue apache#123.
-->
- Closesapache#20853 ## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martin-gmartin-gmartin-g left review comments
@compheadcompheadcomphead approved these changes

Assignees

No one assigned

Labels

commonRelated to common cratecoreCore DataFusion cratedevelopment-processRelated to development process of DataFusionfunctionsChanges to functions implementationlogical-exprLogical plan and expressionsphysical-exprChanges to the physical-expr cratessqlSQL Planner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove paste crate from the project

4 participants

@coderfender@comphead@alamb@martin-g