Uh oh!
There was an error while loading. Please reload this page.
fix: date overflow panic - #21233
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
xudong963
approved these changes
Mar 30, 2026
haohuaijin
commented
Mar 30, 2026
ContributorAuthor
the test case failed, but look like unrelated to my change. |
alamb
commented
Mar 30, 2026
Contributor
I think it was fixed by @mbutrovich here I merged you PR up from main to get the latest code Thank you |
Contributor
Thanks @xudong963 and @xiedeyantu and @haohuaijin |
Uh oh!
There was an error while loading. Please reload this page.
Rich-T-kid pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closesapache#123` indicates that this PR will close issue apache#123. --> - Closesapache#21234 ## Rationale for this change - see apache#21234 ## What changes are included in this PR? handle Date32 and Date64 in `get_extreme_value` function ## Are these changes tested? yes, add test case ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
handle Date32 and Date64 in
get_extreme_valuefunctionAre these changes tested?
yes, add test case
Are there any user-facing changes?