Uh oh!
There was an error while loading. Please reload this page.
PushdownFilter optimizations - #21668
Conversation
8db87e3 to
7aee0a0Compare7aee0a0 to
6ce2a70ComparekumarUjjawal
commented
Apr 16, 2026
@joroKr21 If the direction is agreed by the reviewer you should combine the pr, I will be happy to help. |
6ce2a70 to
740cf2cCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kumarUjjawal
commented
Apr 29, 2026
show benchmark queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kumarUjjawal
commented
Apr 29, 2026
@joroKr21 The benchmarks are slower, can you investigate this. |
joroKr21
commented
Apr 30, 2026
The benchmark from the issue is |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
joroKr21
commented
May 1, 2026
This is the relevant benchmark: |
This comment has been minimized.
This comment has been minimized.
kumarUjjawal
commented
May 1, 2026
@joroKr21 the sql extended timed out last time, i have ran with filter let's see |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dandandan
commented
May 1, 2026
Me and Claude found some other issue here (returning |
This comment has been minimized.
This comment has been minimized.
80c54c0 to
8c2db0dComparealamb
commented
May 20, 2026
Could you please merge up from main and I'll give it a final review |
| /// Skips the type-checking and dealiasing done in [Self::try_new]. | ||
| /// For internal use in DataFusion only. | ||
| /// | ||
| /// **Preconditions:** |
This comment has been minimized.
This comment has been minimized.
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)DetailsResource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)DetailsResource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)DetailsResource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)DetailsResource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)DetailsResource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
alamb
commented
May 20, 2026
run benchmark sql_planner_extended |
adriangbot
commented
May 20, 2026
Benchmark for this request hit the 7200s job deadline before finishing. Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
🤖 Criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing opt/pushdown-filter (4b44591) to 70caf37 (merge-base) diff File an issue against this benchmark runner |
adriangbot
commented
May 20, 2026
Benchmark for this request hit the 7200s job deadline before finishing. Benchmarks requested: Kubernetes messageFile an issue against this benchmark runner |
Uh oh!
There was an error while loading. Please reload this page.
Which issue does this PR close?
try_uncheckedmore so I would adopt thatRationale for this change
What changes are included in this PR?
Filter::newconstructor that skips type-checkingAre these changes tested?
Relying on existing tests mostly, added a few more tests.
Are there any user-facing changes?
make_filteris deprecated, probably wasn't meant to be a public function.