Uh oh!
There was an error while loading. Please reload this page.
feat[expr-common]: support REE in coalesce - #21919
Merged
Merged
Conversation
asubiottoforce-pushed
the
asubiotto/coalesce
branch
from
April 29, 2026 12:21
67d05ca to
d855822Compareasubiotto
commented
Apr 29, 2026
ContributorAuthor
alamb
commented
Apr 29, 2026
Contributor
The failing CI check is new. I was added today. I posted an issue about this failure |
asubiottoforce-pushed
the
asubiotto/coalesce
branch
from
April 30, 2026 06:21
d855822 to
fd23623Comparerluvaton
commented
Apr 30, 2026
Member
Hey, the fix for the detect breaking changes CI is now resolved, can you please align with main? |
We were missing a couple of branches to unwrap REE in type_union_resolution_coercion. Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
asubiottoforce-pushed
the
asubiotto/coalesce
branch
from
April 30, 2026 08:34
fd23623 to
373e240Compareasubiotto
commented
Apr 30, 2026
ContributorAuthor
Rebased, thanks! |
Jefffrey
commented
May 1, 2026
Contributor
Thanks @asubiotto |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were missing a couple of branches to unwrap REE in type_union_resolution_coercion.
Which issue does this PR close?
Rationale for this change
Fix an unexpected error
What changes are included in this PR?
Type coercion match arms for REE
Are these changes tested?
Yes, via sql logic tests
Are there any user-facing changes?
Queries that errored now complete successfully