Deduplicate InList primitive static filters by geoffreyclaude · Pull Request #21932 · apache/datafusion

geoffreyclaude · 2026-04-29T16:13:50Z

Which issue does this PR close?

Part of Further improve performance of IN list evaluation #19241.
Addresses the duplication called out in Refactor InListExpr into static-filter modules #21649 (comment).

Rationale for this change

The existing primitive IN LIST static filters have separate integer and float macros. The float version exists only to wrap values in OrderedFloat* for hash/equality semantics, but the rest of the implementation is copied from the integer path, including the SQL three-valued-logic result construction.

This PR removes that duplication independently from the larger and more controversial direct-probe optimization in #19390.

What changes are included in this PR?

Generalizes the existing primitive_static_filter! macro so it can optionally use a different stored HashSet value type and conversion function.
Keeps the original two-argument primitive_static_filter!(..., ...) form for integer filters.
Keeps the original float_static_filter!(..., ..., OrderedFloat*) call sites, but makes float_static_filter! delegate to primitive_static_filter! instead of duplicating the full implementation.
Preserves the existing HashSet lookup strategy and OrderedFloat* bit-pattern handling for Float32 / Float64.

Are these changes tested?

Yes.

Are there any user-facing changes?

No. This is an internal refactor only.

alamb

Thank you @geoffreyclaude -- this looks great to me

alamb · 2026-04-29T16:51:25Z

- Ok(BooleanArray::new(contains_buffer, result_nulls))
- }
- }
+ primitive_static_filter!($Name, $ArrowType, $OrderedType, <$OrderedType>::from);


alamb · 2026-04-29T16:51:51Z

run benchmarks in_list

adriangbot · 2026-04-29T16:54:36Z

🤖 Criterion benchmark running (GKE) | trigger
Instance:c4a-highmem-16 (12 vCPU / 65 GiB) | Linux bench-c4345763663-1919-9tbzm 6.12.55+ #1 SMP Sun Feb 1 08:59:41 UTC 2026 aarch64 GNU/Linux

CPU Details (lscpu)

Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected

Comparing perf/in_list_primitive_result_dedup (6856e94) to 66980e2 (merge-base) diff
BENCH_NAME=in_list
BENCH_COMMAND=cargo bench --features=parquet --bench in_list
BENCH_FILTER=
Results will be posted here when complete

File an issue against this benchmark runner

adriangbot · 2026-04-29T17:02:56Z

🤖 Criterion benchmark completed (GKE) | trigger

Instance:c4a-highmem-16 (12 vCPU / 65 GiB)

CPU Details (lscpu)

Architecture: aarch64
CPU op-mode(s): 64-bit
Byte Order: Little Endian
CPU(s): 16
On-line CPU(s) list: 0-15
Vendor ID: ARM
Model name: Neoverse-V2
Model: 1
Thread(s) per core: 1
Core(s) per cluster: 16
Socket(s): -
Cluster(s): 1
Stepping: r0p1
BogoMIPS: 2000.00
Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma lrcpc dcpop sha3 sm3 sm4 asimddp sha512 sve asimdfhm dit uscat ilrcpc flagm sb paca pacg dcpodp sve2 sveaes svepmull svebitperm svesha3 svesm4 flagm2 frint svei8mm svebf16 i8mm bf16 dgh rng bti
L1d cache: 1 MiB (16 instances)
L1i cache: 1 MiB (16 instances)
L2 cache: 32 MiB (16 instances)
L3 cache: 80 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-15
Vulnerability Gather data sampling: Not affected
Vulnerability Indirect target selection: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1: Mitigation; __user pointer sanitization
Vulnerability Spectre v2: Mitigation; CSV2, BHB
Vulnerability Srbds: Not affected
Vulnerability Tsa: Not affected
Vulnerability Tsx async abort: Not affected
Vulnerability Vmscape: Not affected

Details

group main perf_in_list_primitive_result_dedup
----- ---- -----------------------------------
in_list/Float32/list=100/nulls=0% 1.74 28.3±0.85µs ? ?/sec 1.00 16.3±0.04µs ? ?/sec
in_list/Float32/list=100/nulls=20% 1.39 24.9±0.85µs ? ?/sec 1.00 17.8±0.20µs ? ?/sec
in_list/Float32/list=28/nulls=0% 1.80 72.4±3.31µs ? ?/sec 1.00 40.1±1.08µs ? ?/sec
in_list/Float32/list=28/nulls=20% 1.00 16.4±0.06µs ? ?/sec 3.56 58.4±2.40µs ? ?/sec
in_list/Float32/list=3/nulls=0% 1.00 15.4±0.03µs ? ?/sec 1.00 15.4±0.03µs ? ?/sec
in_list/Float32/list=3/nulls=20% 1.00 15.3±0.02µs ? ?/sec 1.01 15.5±0.03µs ? ?/sec
in_list/Float32/list=8/nulls=0% 1.00 15.5±0.03µs ? ?/sec 1.01 15.7±0.03µs ? ?/sec
in_list/Float32/list=8/nulls=20% 1.00 15.5±0.06µs ? ?/sec 1.00 15.6±0.06µs ? ?/sec
in_list/Int16/list=100/nulls=0% 1.00 50.0±2.74µs ? ?/sec 1.24 61.9±0.70µs ? ?/sec
in_list/Int16/list=100/nulls=20% 1.06 18.2±0.61µs ? ?/sec 1.00 17.2±0.47µs ? ?/sec
in_list/Int16/list=28/nulls=0% 3.81 55.7±1.83µs ? ?/sec 1.00 14.6±0.49µs ? ?/sec
in_list/Int16/list=28/nulls=20% 1.05 40.2±1.73µs ? ?/sec 1.00 38.3±1.02µs ? ?/sec
in_list/Int16/list=3/nulls=0% 1.02 12.3±0.02µs ? ?/sec 1.00 12.1±0.02µs ? ?/sec
in_list/Int16/list=3/nulls=20% 1.01 12.2±0.03µs ? ?/sec 1.00 12.1±0.02µs ? ?/sec
in_list/Int16/list=8/nulls=0% 1.01 12.2±0.06µs ? ?/sec 1.00 12.0±0.02µs ? ?/sec
in_list/Int16/list=8/nulls=20% 1.00 12.0±0.03µs ? ?/sec 1.00 12.0±0.02µs ? ?/sec
in_list/Int32/list=100/nulls=0% 1.09 46.0±0.87µs ? ?/sec 1.00 42.1±0.36µs ? ?/sec
in_list/Int32/list=100/nulls=20% 1.00 19.3±0.60µs ? ?/sec 1.53 29.6±1.32µs ? ?/sec
in_list/Int32/list=28/nulls=0% 3.10 66.2±0.60µs ? ?/sec 1.00 21.4±0.69µs ? ?/sec
in_list/Int32/list=28/nulls=20% 1.00 52.0±2.33µs ? ?/sec 1.10 57.3±1.95µs ? ?/sec
in_list/Int32/list=3/nulls=0% 1.00 12.1±0.02µs ? ?/sec 1.01 12.2±0.02µs ? ?/sec
in_list/Int32/list=3/nulls=20% 1.00 12.1±0.02µs ? ?/sec 1.00 12.1±0.02µs ? ?/sec
in_list/Int32/list=8/nulls=0% 1.02 12.4±0.05µs ? ?/sec 1.00 12.2±0.09µs ? ?/sec
in_list/Int32/list=8/nulls=20% 1.00 12.2±0.02µs ? ?/sec 1.00 12.1±0.13µs ? ?/sec
in_list/TimestampNs/list=100/nulls=0% 1.04 69.4±2.03µs ? ?/sec 1.00 66.9±0.73µs ? ?/sec
in_list/TimestampNs/list=100/nulls=20% 1.01 60.1±1.69µs ? ?/sec 1.00 59.3±1.77µs ? ?/sec
in_list/TimestampNs/list=28/nulls=0% 1.04 53.3±2.27µs ? ?/sec 1.00 51.3±2.47µs ? ?/sec
in_list/TimestampNs/list=28/nulls=20% 1.00 49.9±1.67µs ? ?/sec 1.00 50.1±2.13µs ? ?/sec
in_list/TimestampNs/list=3/nulls=0% 1.00 24.4±0.05µs ? ?/sec 1.00 24.3±0.10µs ? ?/sec
in_list/TimestampNs/list=3/nulls=20% 1.00 28.0±0.45µs ? ?/sec 1.00 28.0±0.42µs ? ?/sec
in_list/TimestampNs/list=8/nulls=0% 1.00 24.9±0.05µs ? ?/sec 1.05 26.1±0.10µs ? ?/sec
in_list/TimestampNs/list=8/nulls=20% 1.00 27.6±0.40µs ? ?/sec 1.00 27.6±0.42µs ? ?/sec
in_list/UInt8/list=100/nulls=0% 1.06 18.9±0.44µs ? ?/sec 1.00 17.8±0.29µs ? ?/sec
in_list/UInt8/list=100/nulls=20% 1.00 22.6±0.75µs ? ?/sec 1.51 34.1±0.83µs ? ?/sec
in_list/UInt8/list=28/nulls=0% 1.38 39.6±0.76µs ? ?/sec 1.00 28.7±0.54µs ? ?/sec
in_list/UInt8/list=28/nulls=20% 1.00 19.5±0.72µs ? ?/sec 1.05 20.4±0.72µs ? ?/sec
in_list/UInt8/list=3/nulls=0% 1.04 12.7±0.16µs ? ?/sec 1.00 12.2±0.03µs ? ?/sec
in_list/UInt8/list=3/nulls=20% 1.00 12.3±0.05µs ? ?/sec 1.03 12.7±0.07µs ? ?/sec
in_list/UInt8/list=8/nulls=0% 1.02 13.0±0.05µs ? ?/sec 1.00 12.7±0.08µs ? ?/sec
in_list/UInt8/list=8/nulls=20% 1.01 12.9±0.13µs ? ?/sec 1.00 12.8±0.04µs ? ?/sec
in_list/Utf8/list=100/nulls=0%/str=100 1.03 96.3±1.75µs ? ?/sec 1.00 93.9±0.50µs ? ?/sec
in_list/Utf8/list=100/nulls=0%/str=12 1.01 59.6±0.48µs ? ?/sec 1.00 59.1±0.56µs ? ?/sec
in_list/Utf8/list=100/nulls=0%/str=3 1.00 106.4±2.21µs ? ?/sec 1.01 107.4±0.57µs ? ?/sec
in_list/Utf8/list=100/nulls=20%/str=100 1.00 101.7±3.19µs ? ?/sec 1.00 101.4±1.21µs ? ?/sec
in_list/Utf8/list=100/nulls=20%/str=12 1.01 77.3±2.06µs ? ?/sec 1.00 76.2±1.50µs ? ?/sec
in_list/Utf8/list=100/nulls=20%/str=3 1.00 72.0±1.41µs ? ?/sec 1.00 71.6±1.41µs ? ?/sec
in_list/Utf8/list=28/nulls=0%/str=100 1.00 136.3±1.19µs ? ?/sec 1.02 138.3±0.77µs ? ?/sec
in_list/Utf8/list=28/nulls=0%/str=12 1.02 71.1±2.38µs ? ?/sec 1.00 69.7±0.44µs ? ?/sec
in_list/Utf8/list=28/nulls=0%/str=3 1.01 101.0±2.20µs ? ?/sec 1.00 100.1±0.80µs ? ?/sec
in_list/Utf8/list=28/nulls=20%/str=100 1.01 140.0±3.19µs ? ?/sec 1.00 138.5±1.68µs ? ?/sec
in_list/Utf8/list=28/nulls=20%/str=12 1.02 88.4±2.66µs ? ?/sec 1.00 86.8±2.02µs ? ?/sec
in_list/Utf8/list=28/nulls=20%/str=3 1.00 70.2±1.98µs ? ?/sec 1.02 71.7±1.70µs ? ?/sec
in_list/Utf8/list=3/nulls=0%/str=100 1.00 71.7±0.37µs ? ?/sec 1.00 71.9±0.55µs ? ?/sec
in_list/Utf8/list=3/nulls=0%/str=12 1.00 33.6±0.08µs ? ?/sec 1.00 33.6±0.07µs ? ?/sec
in_list/Utf8/list=3/nulls=0%/str=3 1.02 35.4±0.17µs ? ?/sec 1.00 34.7±0.07µs ? ?/sec
in_list/Utf8/list=3/nulls=20%/str=100 1.01 76.9±0.69µs ? ?/sec 1.00 76.5±0.46µs ? ?/sec
in_list/Utf8/list=3/nulls=20%/str=12 1.00 37.1±0.25µs ? ?/sec 1.00 37.1±0.29µs ? ?/sec
in_list/Utf8/list=3/nulls=20%/str=3 1.00 39.1±0.40µs ? ?/sec 1.00 39.2±0.25µs ? ?/sec
in_list/Utf8/list=8/nulls=0%/str=100 1.00 72.5±0.23µs ? ?/sec 1.00 72.6±0.29µs ? ?/sec
in_list/Utf8/list=8/nulls=0%/str=12 1.00 34.2±0.07µs ? ?/sec 1.00 34.4±0.11µs ? ?/sec
in_list/Utf8/list=8/nulls=0%/str=3 1.00 35.7±0.06µs ? ?/sec 1.01 36.0±0.14µs ? ?/sec
in_list/Utf8/list=8/nulls=20%/str=100 1.00 77.7±0.65µs ? ?/sec 1.00 77.5±0.41µs ? ?/sec
in_list/Utf8/list=8/nulls=20%/str=12 1.01 37.8±0.33µs ? ?/sec 1.00 37.5±0.37µs ? ?/sec
in_list/Utf8/list=8/nulls=20%/str=3 1.00 39.5±0.39µs ? ?/sec 1.01 40.1±0.63µs ? ?/sec
in_list/Utf8/mixed/list=100/match=0%/nulls=0% 1.00 71.0±0.55µs ? ?/sec 1.00 71.4±1.05µs ? ?/sec
in_list/Utf8/mixed/list=100/match=0%/nulls=20% 1.00 104.7±1.13µs ? ?/sec 1.00 105.0±0.98µs ? ?/sec
in_list/Utf8/mixed/list=100/match=25%/nulls=0% 1.00 130.0±3.24µs ? ?/sec 1.01 131.5±3.71µs ? ?/sec
in_list/Utf8/mixed/list=100/match=25%/nulls=20% 1.00 129.8±3.84µs ? ?/sec 1.01 131.3±3.70µs ? ?/sec
in_list/Utf8/mixed/list=100/match=75%/nulls=0% 1.01 166.2±5.21µs ? ?/sec 1.00 164.8±4.64µs ? ?/sec
in_list/Utf8/mixed/list=100/match=75%/nulls=20% 1.01 161.6±2.58µs ? ?/sec 1.00 160.7±2.84µs ? ?/sec
in_list/Utf8/mixed/list=28/match=0%/nulls=0% 1.00 134.8±0.72µs ? ?/sec 1.01 135.5±0.89µs ? ?/sec
in_list/Utf8/mixed/list=28/match=0%/nulls=20% 1.00 97.1±1.47µs ? ?/sec 1.00 96.9±1.23µs ? ?/sec
in_list/Utf8/mixed/list=28/match=25%/nulls=0% 1.00 155.7±3.16µs ? ?/sec 1.02 158.2±3.71µs ? ?/sec
in_list/Utf8/mixed/list=28/match=25%/nulls=20% 1.00 130.9±3.76µs ? ?/sec 1.03 134.5±1.35µs ? ?/sec
in_list/Utf8/mixed/list=28/match=75%/nulls=0% 1.00 170.0±4.48µs ? ?/sec 1.00 169.4±2.40µs ? ?/sec
in_list/Utf8/mixed/list=28/match=75%/nulls=20% 1.00 163.8±2.71µs ? ?/sec 1.01 165.4±2.83µs ? ?/sec
in_list/Utf8/mixed/list=3/match=0%/nulls=0% 1.00 46.3±0.25µs ? ?/sec 1.00 46.2±0.28µs ? ?/sec
in_list/Utf8/mixed/list=3/match=0%/nulls=20% 1.00 66.9±1.01µs ? ?/sec 1.00 66.6±1.16µs ? ?/sec
in_list/Utf8/mixed/list=3/match=25%/nulls=0% 1.01 79.8±1.68µs ? ?/sec 1.00 79.2±1.05µs ? ?/sec
in_list/Utf8/mixed/list=3/match=25%/nulls=20% 1.00 85.6±1.75µs ? ?/sec 1.00 85.6±1.87µs ? ?/sec
in_list/Utf8/mixed/list=3/match=75%/nulls=0% 1.00 111.4±2.54µs ? ?/sec 1.00 111.0±2.10µs ? ?/sec
in_list/Utf8/mixed/list=3/match=75%/nulls=20% 1.00 119.8±2.89µs ? ?/sec 1.01 120.5±3.52µs ? ?/sec
in_list/Utf8/mixed/list=8/match=0%/nulls=0% 1.00 47.7±0.36µs ? ?/sec 1.00 47.7±0.34µs ? ?/sec
in_list/Utf8/mixed/list=8/match=0%/nulls=20% 1.00 65.6±0.96µs ? ?/sec 1.01 65.9±1.15µs ? ?/sec
in_list/Utf8/mixed/list=8/match=25%/nulls=0% 1.00 86.8±2.14µs ? ?/sec 1.00 87.1±2.03µs ? ?/sec
in_list/Utf8/mixed/list=8/match=25%/nulls=20% 1.03 94.2±1.52µs ? ?/sec 1.00 91.4±2.86µs ? ?/sec
in_list/Utf8/mixed/list=8/match=75%/nulls=0% 1.00 143.8±3.00µs ? ?/sec 1.00 144.0±2.77µs ? ?/sec
in_list/Utf8/mixed/list=8/match=75%/nulls=20% 1.00 132.2±2.54µs ? ?/sec 1.01 133.4±1.87µs ? ?/sec
in_list/Utf8View/list=100/nulls=0%/str=100 1.01 111.5±0.98µs ? ?/sec 1.00 110.9±0.64µs ? ?/sec
in_list/Utf8View/list=100/nulls=0%/str=12 1.02 44.3±0.65µs ? ?/sec 1.00 43.6±0.78µs ? ?/sec
in_list/Utf8View/list=100/nulls=0%/str=3 1.04 55.7±2.47µs ? ?/sec 1.00 53.3±1.05µs ? ?/sec
in_list/Utf8View/list=100/nulls=20%/str=100 1.00 112.3±1.40µs ? ?/sec 1.02 114.3±2.68µs ? ?/sec
in_list/Utf8View/list=100/nulls=20%/str=12 1.00 70.2±1.55µs ? ?/sec 1.01 70.8±1.53µs ? ?/sec
in_list/Utf8View/list=100/nulls=20%/str=3 1.00 47.5±1.34µs ? ?/sec 1.00 47.4±0.85µs ? ?/sec
in_list/Utf8View/list=28/nulls=0%/str=100 1.00 124.9±0.51µs ? ?/sec 1.01 126.2±1.20µs ? ?/sec
in_list/Utf8View/list=28/nulls=0%/str=12 1.02 76.2±1.35µs ? ?/sec 1.00 74.8±0.82µs ? ?/sec
in_list/Utf8View/list=28/nulls=0%/str=3 1.00 43.9±1.51µs ? ?/sec 1.02 44.8±1.82µs ? ?/sec
in_list/Utf8View/list=28/nulls=20%/str=100 1.00 116.3±1.71µs ? ?/sec 1.00 116.0±1.51µs ? ?/sec
in_list/Utf8View/list=28/nulls=20%/str=12 1.00 55.4±2.33µs ? ?/sec 1.01 55.9±1.32µs ? ?/sec
in_list/Utf8View/list=28/nulls=20%/str=3 1.00 55.2±1.35µs ? ?/sec 1.01 55.5±2.13µs ? ?/sec
in_list/Utf8View/list=3/nulls=0%/str=100 1.00 82.7±0.26µs ? ?/sec 1.00 82.7±0.27µs ? ?/sec
in_list/Utf8View/list=3/nulls=0%/str=12 1.00 25.2±0.06µs ? ?/sec 1.00 25.1±0.10µs ? ?/sec
in_list/Utf8View/list=3/nulls=0%/str=3 1.06 26.8±0.07µs ? ?/sec 1.00 25.2±0.06µs ? ?/sec
in_list/Utf8View/list=3/nulls=20%/str=100 1.01 84.2±1.52µs ? ?/sec 1.00 83.4±0.89µs ? ?/sec
in_list/Utf8View/list=3/nulls=20%/str=12 1.01 30.1±0.50µs ? ?/sec 1.00 29.9±0.41µs ? ?/sec
in_list/Utf8View/list=3/nulls=20%/str=3 1.00 30.0±0.48µs ? ?/sec 1.00 29.9±0.43µs ? ?/sec
in_list/Utf8View/list=8/nulls=0%/str=100 1.00 83.5±0.49µs ? ?/sec 1.00 83.3±0.25µs ? ?/sec
in_list/Utf8View/list=8/nulls=0%/str=12 1.00 26.1±0.08µs ? ?/sec 1.01 26.2±0.07µs ? ?/sec
in_list/Utf8View/list=8/nulls=0%/str=3 1.03 26.8±0.68µs ? ?/sec 1.00 25.9±0.06µs ? ?/sec
in_list/Utf8View/list=8/nulls=20%/str=100 1.00 83.5±0.88µs ? ?/sec 1.00 83.3±1.36µs ? ?/sec
in_list/Utf8View/list=8/nulls=20%/str=12 1.00 29.8±0.42µs ? ?/sec 1.01 30.1±0.51µs ? ?/sec
in_list/Utf8View/list=8/nulls=20%/str=3 1.00 29.8±0.75µs ? ?/sec 1.01 30.1±0.53µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=0%/nulls=0% 1.00 78.8±0.93µs ? ?/sec 1.01 79.2±1.39µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=0%/nulls=20% 1.00 98.6±1.98µs ? ?/sec 1.01 100.0±1.62µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=25%/nulls=0% 1.00 106.0±3.95µs ? ?/sec 1.01 107.3±3.31µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=25%/nulls=20% 1.00 102.3±3.28µs ? ?/sec 1.01 103.8±1.84µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=75%/nulls=0% 1.00 128.3±3.01µs ? ?/sec 1.01 129.7±2.68µs ? ?/sec
in_list/Utf8View/mixed/list=100/match=75%/nulls=20% 1.00 124.3±3.54µs ? ?/sec 1.00 124.1±3.08µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=0%/nulls=0% 1.00 104.4±1.56µs ? ?/sec 1.00 104.4±0.94µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=0%/nulls=20% 1.00 103.8±2.04µs ? ?/sec 1.00 103.7±1.92µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=25%/nulls=0% 1.00 136.4±4.86µs ? ?/sec 1.00 136.8±3.94µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=25%/nulls=20% 1.00 106.3±2.14µs ? ?/sec 1.01 107.3±2.05µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=75%/nulls=0% 1.00 134.9±3.17µs ? ?/sec 1.01 135.7±2.62µs ? ?/sec
in_list/Utf8View/mixed/list=28/match=75%/nulls=20% 1.00 126.3±3.59µs ? ?/sec 1.00 126.9±2.51µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=0%/nulls=0% 1.00 37.0±0.22µs ? ?/sec 1.01 37.3±0.17µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=0%/nulls=20% 1.00 41.0±0.42µs ? ?/sec 1.01 41.2±0.45µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=25%/nulls=0% 1.01 74.1±2.05µs ? ?/sec 1.00 73.4±1.53µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=25%/nulls=20% 1.00 74.9±2.35µs ? ?/sec 1.01 75.4±2.01µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=75%/nulls=0% 1.00 88.1±1.00µs ? ?/sec 1.01 89.4±2.07µs ? ?/sec
in_list/Utf8View/mixed/list=3/match=75%/nulls=20% 1.00 112.6±1.78µs ? ?/sec 1.01 113.2±2.24µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=0%/nulls=0% 1.00 37.7±0.19µs ? ?/sec 1.00 37.8±0.18µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=0%/nulls=20% 1.00 41.0±0.39µs ? ?/sec 1.00 41.2±0.38µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=25%/nulls=0% 1.01 66.4±2.59µs ? ?/sec 1.00 65.8±1.98µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=25%/nulls=20% 1.00 62.8±0.97µs ? ?/sec 1.01 63.6±1.86µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=75%/nulls=0% 1.00 79.5±0.81µs ? ?/sec 1.01 80.3±1.52µs ? ?/sec
in_list/Utf8View/mixed/list=8/match=75%/nulls=20% 1.00 105.2±2.03µs ? ?/sec 1.00 105.8±2.27µs ? ?/sec
in_list_cols/Int32/list=28/match=0%/nulls=0% 1.01 51.7±0.29µs ? ?/sec 1.00 51.3±0.25µs ? ?/sec
in_list_cols/Int32/list=28/match=0%/nulls=20% 1.02 66.3±0.27µs ? ?/sec 1.00 64.7±0.33µs ? ?/sec
in_list_cols/Int32/list=28/match=100%/nulls=0% 1.00 1830.3±7.37ns ? ?/sec 1.00 1832.7±5.16ns ? ?/sec
in_list_cols/Int32/list=28/match=100%/nulls=20% 1.01 66.1±0.42µs ? ?/sec 1.00 65.6±0.23µs ? ?/sec
in_list_cols/Int32/list=28/match=50%/nulls=0% 1.00 27.4±0.05µs ? ?/sec 1.00 27.5±0.05µs ? ?/sec
in_list_cols/Int32/list=28/match=50%/nulls=20% 1.02 66.4±0.24µs ? ?/sec 1.00 65.2±0.25µs ? ?/sec
in_list_cols/Int32/list=3/match=0%/nulls=0% 1.00 5.5±0.02µs ? ?/sec 1.00 5.5±0.01µs ? ?/sec
in_list_cols/Int32/list=3/match=0%/nulls=20% 1.00 6.6±0.02µs ? ?/sec 1.00 6.6±0.02µs ? ?/sec
in_list_cols/Int32/list=3/match=100%/nulls=0% 1.00 1825.2±3.36ns ? ?/sec 1.01 1845.7±4.99ns ? ?/sec
in_list_cols/Int32/list=3/match=100%/nulls=20% 1.01 6.6±0.03µs ? ?/sec 1.00 6.6±0.04µs ? ?/sec
in_list_cols/Int32/list=3/match=50%/nulls=0% 1.00 5.5±0.02µs ? ?/sec 1.00 5.5±0.02µs ? ?/sec
in_list_cols/Int32/list=3/match=50%/nulls=20% 1.00 6.6±0.05µs ? ?/sec 1.00 6.6±0.02µs ? ?/sec
in_list_cols/Int32/list=8/match=0%/nulls=0% 1.00 14.6±0.04µs ? ?/sec 1.00 14.6±0.05µs ? ?/sec
in_list_cols/Int32/list=8/match=0%/nulls=20% 1.02 18.4±0.11µs ? ?/sec 1.00 18.1±0.05µs ? ?/sec
in_list_cols/Int32/list=8/match=100%/nulls=0% 1.00 1831.8±7.68ns ? ?/sec 1.00 1835.5±9.02ns ? ?/sec
in_list_cols/Int32/list=8/match=100%/nulls=20% 1.01 18.4±0.04µs ? ?/sec 1.00 18.2±0.14µs ? ?/sec
in_list_cols/Int32/list=8/match=50%/nulls=0% 1.00 14.6±0.06µs ? ?/sec 1.00 14.7±0.05µs ? ?/sec
in_list_cols/Int32/list=8/match=50%/nulls=20% 1.00 18.3±0.05µs ? ?/sec 1.00 18.2±0.09µs ? ?/sec
in_list_cols/Utf8/list=28/match=0% 1.01 177.2±0.87µs ? ?/sec 1.00 175.7±0.35µs ? ?/sec
in_list_cols/Utf8/list=28/match=100% 1.00 711.7±6.46µs ? ?/sec 1.01 718.2±1.58µs ? ?/sec
in_list_cols/Utf8/list=28/match=50% 1.00 1152.3±1.92µs ? ?/sec 1.00 1151.9±1.50µs ? ?/sec
in_list_cols/Utf8/list=3/match=0% 1.00 18.6±0.03µs ? ?/sec 1.00 18.5±0.03µs ? ?/sec
in_list_cols/Utf8/list=3/match=100% 1.01 75.5±0.27µs ? ?/sec 1.00 75.1±0.21µs ? ?/sec
in_list_cols/Utf8/list=3/match=50% 1.00 97.6±1.56µs ? ?/sec 1.06 102.9±0.88µs ? ?/sec
in_list_cols/Utf8/list=8/match=0% 1.01 50.5±0.39µs ? ?/sec 1.00 50.1±0.14µs ? ?/sec
in_list_cols/Utf8/list=8/match=100% 1.01 204.1±0.72µs ? ?/sec 1.00 202.6±1.03µs ? ?/sec
in_list_cols/Utf8/list=8/match=50% 1.00 311.5±1.60µs ? ?/sec 1.03 321.3±0.51µs ? ?/sec

Resource Usage

base (merge-base)

Metric	Value
Wall time	170.0s
Peak memory	4.5 GiB
Avg memory	4.5 GiB
CPU user	586.6s
CPU sys	2.3s
Peak spill	0 B

branch

Metric	Value
Wall time	165.0s
Peak memory	4.5 GiB
Avg memory	4.5 GiB
CPU user	587.2s
CPU sys	1.8s
Peak spill	0 B

File an issue against this benchmark runner

alamb · 2026-04-29T19:13:27Z

I think the results look good -- the few slowdowns I think are outliers. Since this is just a refactoring I just clicked the merge button. Thanks again @geoffreyclaude

github-actionsBot added the physical-expr Changes to the physical-expr crates label Apr 29, 2026

geoffreyclaude force-pushed the perf/in_list_primitive_result_dedup branch 4 times, most recently from 134f354 to 9904dccCompare April 29, 2026 16:32

Deduplicate InList primitive static filters
6856e94

geoffreyclaude force-pushed the perf/in_list_primitive_result_dedup branch from 9904dcc to 6856e94Compare April 29, 2026 16:35

geoffreyclaude mentioned this pull request Apr 29, 2026
Refactor InListExpr into static-filter modules #21649
Merged

alamb approved these changes Apr 29, 2026
View reviewed changes

alamb added this pull request to the merge queue Apr 29, 2026

Merged via the queue into apache:main with commit 985f0a4Apr 29, 2026
40 checks passed

Navigation Menu

Uh oh!

Deduplicate InList primitive static filters - #21932

Deduplicate InList primitive static filters#21932
alamb merged 1 commit into
apache:mainfrom
geoffreyclaude:perf/in_list_primitive_result_dedup

geoffreyclaude commented Apr 29, 2026•
edited
Loading

Uh oh!

alamb left a comment

Uh oh!

alambApr 29, 2026

Uh oh!

alamb commented Apr 29, 2026

Uh oh!

adriangbot commented Apr 29, 2026

Uh oh!

adriangbot commented Apr 29, 2026

Uh oh!

alamb commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

geoffreyclaude commented Apr 29, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

alamb left a comment

Choose a reason for hiding this comment

Uh oh!

alambApr 29, 2026

Choose a reason for hiding this comment

Uh oh!

alamb commented Apr 29, 2026

Uh oh!

adriangbot commented Apr 29, 2026

Uh oh!

adriangbot commented Apr 29, 2026

Uh oh!

alamb commented Apr 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

geoffreyclaude commented Apr 29, 2026•
edited
Loading