Skip to content

[Ballista] Docker files for ui - #22

Merged
andygrove merged 3 commits into
apache:masterfrom
msathis:docker-ui
Apr 24, 2021
Merged

[Ballista] Docker files for ui#22
andygrove merged 3 commits into
apache:masterfrom
msathis:docker-ui

Conversation

@msathis

@msathismsathis commented Apr 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Do we have docker-compose where we can setup the entire system? I searched but couldn't find it. If it is, I would like to include the ui deployment there.

@codecov-commenter

codecov-commenter commented Apr 21, 2021

Copy link
Copy Markdown

Codecov Report

Merging #22 (88c5266) into master (c365a4f) will not change coverage.
The diff coverage is n/a.

❗ Current head 88c5266 differs from pull request most recent head c2f5e42. Consider uploading reports for the commit c2f5e42 to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@## master #22 +/- ##
=======================================
Coverage 70.41% 70.41% =======================================
Files 123 123 Lines 21261 21261 =======================================
Hits 14970 14970 Misses 6291 6291

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c365a4f...c2f5e42. Read the comment docs.

@msathismsathis changed the title Docker files for ui[Ballista] Docker files for uiApr 21, 2021
@andygrove

andygrove commented Apr 21, 2021

Copy link
Copy Markdown
Member

Do we have docker-compose where we can setup the entire system? I searched but couldn't find it. If it is, I would like to include the ui deployment there.

There is a docker compose yaml under the ballista benchmark but we might want to consider moving this to a higher level as we get Ballista more integrated into this repo.

@msathis

msathis commented Apr 22, 2021

Copy link
Copy Markdown
ContributorAuthor

@andygrove Hi, Can we merge this now or we want to wait for the integrated docker-compose setup to be in place?

andygrove
andygrove reviewed Apr 22, 2021
View reviewed changes
Comment threaddev/build-ui.sh
# specific language governing permissions and limitations
# under the License.

BALLISTA_VERSION=0.4.2-SNAPSHOT

@andygroveandygroveApr 22, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to fix in this PR but I filed for #32 for removing these hard-coded versions

@msathismsathisApr 22, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

andygrove
andygrove reviewed Apr 22, 2021
View reviewed changes
Comment threadballista/ui/scheduler/.dockerignore Outdated
@andygrove

andygrove commented Apr 22, 2021

Copy link
Copy Markdown
Member

@andygrove Hi, Can we merge this now or we want to wait for the integrated docker-compose setup to be in place?

I think we just need to wait on #29 to finish getting the process in place for the repo.

andygrove
andygrove approved these changes Apr 22, 2021
View reviewed changes

@andygroveandygrove left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msathis

msathis commented Apr 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@andygrove Hi, I am going to work on #32 next. If we can merge this, i can fix all hard coded BALLISTA_VERSION at one go.

@andygrove

andygrove commented Apr 24, 2021

Copy link
Copy Markdown
Member

Closes #45

@andygroveandygrove linked an issue Apr 24, 2021 that may be closed by this pull request
Add Dockerfile for Ballista scheduler UI #45
Closed
@andygrove
andygrove merged commit 3cb83fe into apache:masterApr 24, 2021
@houqphouqp added ballista enhancement New feature or request labels Jul 29, 2021
alamb pushed a commit that referenced this pull request Jul 23, 2024
@sgrebnov
Improve unparser MySQL compatibility (#11589)
65dd364
* Configurable date field extraction style for unparsing (#21)
* Add support for IntervalStyle::MySQL (#18)
* Support alternate format for Int64 unparsing (SIGNED for MySQL) (#22)
* Alternate format support for Timestamp casting (DATETIME for MySQL) (#23)
* Improve
* Fix clippy and docs
berkaysynnada added a commit that referenced this pull request Apr 17, 2025
@adriangb@alamb@berkaysynnada
ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply…
112cde8
… them (#15566)
* ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply them
* wip
* fix tests
* fix
* fix
* fix doc
* fix doc
* Improve doc comments of `filter-pushdown-apis` (#22)
* Improve doc comments
* Apply suggestions from code review
---------
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* simplify according to pr feedback
* Add missing file
* Add tests
* pipe config in
* docstrings
* Update datafusion/physical-plan/src/filter_pushdown.rs
* fix
* fix
* fmt
* fix doc
* add example usage of config
* fix test
* convert exec API and optimizer rule
* re-add docs
* dbg
* dbg 2
* avoid clones
* part 3
* fix lint
* tests pass
* Update filter.rs
* update projection tests
* update slt files
* fix
* fix references
* improve impls and update tests
* apply stop logic
* update slt's
* update other tests
* minor
* rename modules to match logical optimizer, tweak docs
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: berkaysynnada <berkay.sahin@synnada.ai>
Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
nirnayroy pushed a commit to nirnayroy/datafusion that referenced this pull request May 2, 2025
@adriangb@alamb
@berkaysynnada@cipherstakes
ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply…
7f4180b
… them (apache#15566)
* ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply them
* wip
* fix tests
* fix
* fix
* fix doc
* fix doc
* Improve doc comments of `filter-pushdown-apis` (apache#22)
* Improve doc comments
* Apply suggestions from code review
---------
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* simplify according to pr feedback
* Add missing file
* Add tests
* pipe config in
* docstrings
* Update datafusion/physical-plan/src/filter_pushdown.rs
* fix
* fix
* fmt
* fix doc
* add example usage of config
* fix test
* convert exec API and optimizer rule
* re-add docs
* dbg
* dbg 2
* avoid clones
* part 3
* fix lint
* tests pass
* Update filter.rs
* update projection tests
* update slt files
* fix
* fix references
* improve impls and update tests
* apply stop logic
* update slt's
* update other tests
* minor
* rename modules to match logical optimizer, tweak docs
---------
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: berkaysynnada <berkay.sahin@synnada.ai>
Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
duongcongtoai added a commit to irenjj/datafusion that referenced this pull request Jul 12, 2025
@duongcongtoai
Merge pull requestapache#22from irenjj/fix_detect_correlated_expres…
69debc0
…sions
Fix detect correlated expressions
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andygroveandygroveandygrove approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Dockerfile for Ballista scheduler UI

4 participants

@msathis@codecov-commenter@andygrove@houqp