Uh oh!
There was an error while loading. Please reload this page.
perf: Use NullBuffer::union_many - #22070
Merged
mbutrovich merged 2 commits intoMay 8, 2026
Merged
Conversation
neilconway
commented
May 7, 2026
ContributorAuthor
There's one remaining place we could use |
neilconway
commented
May 7, 2026
ContributorAuthor
FYI @mbutrovich |
mbutrovich
self-requested a review
May 7, 2026 21:16
kosiew
approved these changes
May 8, 2026
kosiew
left a comment
Contributor
There was a problem hiding this comment.
@neilconway
Thanks for working on this.
Looks 👍 to me
alamb
commented
May 8, 2026
Contributor
AMAZING! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NullBuffer::union_manywhen appropriate #21880.Rationale for this change
Now that
NullBuffer::union_manyhas landed in arrow-rs 58.2, we can use it to simplify and speedup various places in DataFusion that were union'ing together > 2 null buffers. In such cases,union_manyavoids the intermediate allocations that are done by repeatedunioncalls.What changes are included in this PR?
NullBuffer::union_manythroughout the codebasecompute_null_maskin the Spark crate to be more readable and avoid needlessly padding scalars out to arrays just to compute the null maskAre these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
No.